[gnutls-devel] GnuTLS | WIP: system config disable KTLS (!1559)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Mar 25 09:21:16 CET 2022




Daiki Ueno started a new discussion on lib/includes/gnutls/socket.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1559#note_888617176

>   * Since: 3.7.3
>   */
>  typedef enum {
> -	GNUTLS_KTLS_RECV = 1 << 0,
> -	GNUTLS_KTLS_SEND = 1 << 1,
> +	GNUTLS_KTLS_CONFIG_ENABLED = 1 << 0,
> +	GNUTLS_KTLS_RECV = 1 << 1,

This way of changing enums is not backward compatible (the programs compiled with previous version of GnuTLS will be confused with `GNUTLS_KTLS_RECV` and `GNUTLS_KTLS_SEND`). I'd move `GNUTLS_KTLS_CONFIG_ENABLED` to the end (i.e., `1 << 2`), though I would rather suggest not touching this enum. If KTLS is disabled by the config, `gnutls_transport_is_ktls_enabled` will always return 0.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1559#note_888617176
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220325/462b1785/attachment.html>


More information about the Gnutls-devel mailing list