[gnutls-devel] GnuTLS | psk_ke_modes_recv_params() wrongly sets HSK_PSK_KE_MODE_INVALID (#1303)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Mar 28 18:25:16 CEST 2022




Tim Kosse commented:


I'm sorry, missed Daiki's reply. I've now mailed the patch using `git send-email` including the `Signed-off-by:` line.

> the logic seems to be correct, though I wonder if it could be simpler if we use `-1` as the indication of "unset", instead of `MAX_POS`, as in ext/supported_groups.c.

Isn't this seeming simplicity an artifact from dealing specifically with just two options? How would this look like in the general case of _n_ options to choose from? Even in the case of just two options, I think it is more difficult to than it appears, hence this bug report.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1303#note_891730481
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220328/2e014624/attachment.html>


More information about the Gnutls-devel mailing list