[gnutls-devel] GnuTLS | Fipshmac: always use realpaths (!1666)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1666 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1666#note_1165972171

>  	ret = 0;
>  cleanup:
> +	gnutls_free(real_path);

nit: we should use `free` instead of `gnutls_free` (these days they are the same, but `gnutls_free` should only be used on memory areas that are allocated with `gnutls_malloc` etc.)

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1666#note_1165972177

>  
> -	ret = snprintf(path, path_size, "%s", info.dli_fname);
> +	real_path = realpath(info.dli_fname, NULL);

nit: using `canonicalize_file_name` might be slightly more readable (as we can omit the second argument)


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1666
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221109/fa668666/attachment.html>