[gnutls-devel] GnuTLS | tests: More SIGPIPE treatment as error (!1668)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Nov 16 02:08:14 CET 2022



Samuel Thibault created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1668

Project:Branches: sthibaul/gnutls:SIGPIPE to gnutls/gnutls:master
Author:   Samuel Thibault




    81f8d97b3486 ("tests: treat all signals as error") turned some SIGPIPE signals
    to EPIPE, but missed tests/mini-dtls-mtu.c.

    During
    
    gnutls_bye(session, GNUTLS_SHUT_WR),
    
    on Linux we get
    
    client|<11>| WRITE: enqueued 39 bytes for 0x3. Total 39 bytes.
    client|<11>| WRITE FLUSH: 39 bytes in buffer.
    client|<2>| WRITE: -1 returned from 0x3, errno: 111
    (ECONNREFUSED)
    
    but on GNU/Hurd a SIGPIPE is sent instead of returning of ECONNREFUSED.
    We thus need to turn it into an error to correctly interpret the test
    result.

This happens to be the only gnutls28 testsuite failure on GNU/Hurd.

## Checklist
 * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [X] Code modified for feature
 * [N/A] Test suite updated with functionality tests
 * [N/A] Test suite updated with negative tests
 * [X] Documentation updated / NEWS entry present (for non-trivial changes)
 * [X] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1668
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221116/a7ec96bb/attachment.html>


More information about the Gnutls-devel mailing list