[gnutls-devel] GnuTLS | fips: rename .gnutls.hmac back to .libgnutls.so.*.hmac (!1674)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1674 was reviewed by Zoltán Fridrich

--
  <!-- Get preloaded note discussion-->
  
Zoltán Fridrich started a new discussion on lib/fips.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1674#note_1191160959

>  	}
>  
> -	ret = 0;

I would not remove this. The get_library_path function returns gnutls error code which should be GNUTLS_E_SUCCESS aka 0. By removing this line, the check (ret == GNUTLS_E_SUCCESS) would fail even though the function finished correctly. Thats because snprintf returns number of bytes written which is temporarily stored in ret.

Maybe change it into ret = GNUTLS_E_SUCCESS;


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1674
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221130/eee4884c/attachment-0001.html>