[gnutls-devel] GnuTLS | gnutls_init: Always initialize *session (!1652)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1652 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/x509/crl.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1652#note_1136952436

>  			gnutls_assert();
>  			gnutls_free(*crl);
> +                        *crl = NULL;

This line shouldn't be necessary as `gnutls_free` is defined as a macro: `#define gnutls_free(a) gnutls_free((void *) (a)), a=NULL`.

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/pkcs11_privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1652#note_1136952437

>  	(*key)->uinfo = p11_kit_uri_new();
>  	if ((*key)->uinfo == NULL) {
>  		free(*key);

Not an issue in this MR, but this line should use `gnutls_free`. We probably should have an automated way to detect such mismatches.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1652
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221015/85fdec1e/attachment-0001.html>