[gnutls-devel] GnuTLS | Ignore unknown algorithms received in compress_certificate extension (!1660)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1660 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/ext/compress_certificate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1660#note_1144359691

>  		num = _gnutls_read_uint16(data + i + i + 1);
>  		methods[i] = _gnutls_compress_certificate_num2method(num);
> -		if (methods[i] == GNUTLS_COMP_UNKNOWN)

This check is legitimate: we should reject any unknown codepoint for a compression algorithm.

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/ext/compress_certificate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1660#note_1144359696

>  				method = methods[i];
>  				goto endloop;
>  			}

The fallthrough logic should probably be here instead.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1660
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221021/7deba990/attachment.html>