[gnutls-devel] GnuTLS | Report system config file location via gnutls-cli (!1639)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1639 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/global.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1639#note_1095547149

>   *
> - * Returns: a NUL-terminated %gnutls_library_config_st array
> + * Returns: a NULL-terminated %gnutls_library_config_st array

nit: it's not a typo https://en.wikipedia.org/wiki/Null_character

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/global.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1639#note_1095547152

> +	while (strcmp(_gnutls_library_config[i].name, "system-config"))
> +		++i;
> +	_gnutls_library_config[i].value = gnutls_get_system_config_file();

Instead of introducing a side-effect, I would rather put the logic in src/cli.c, something like:
```c
        if (HAVE_OPT(LIST_CONFIG)) {
                const gnutls_library_config_st *p;

                for (p = gnutls_get_library_config(); p->name; p++) {
                        log_msg(stdout, "%s: %s\n", p->name, p->value);
                }
                log_msg(stdout, "system-config: %s\n", gnutls_get_system_config_file());
                exit(0);
        }
```


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1639
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220909/2a331bb1/attachment-0001.html>