[gnutls-devel] GnuTLS | Make XTS key check failure not fatal (!1648)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1648 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/nettle/cipher.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1648#note_1119254684

> +	case GNUTLS_CIPHER_AES_256_XTS:
> +		if (_gnutls_fips_mode_enabled() &&
> +		    gnutls_memcmp(key, (char *)key + AES128_KEY_SIZE, AES128_KEY_SIZE) == 0)

This condition only works with `GNUTLS_CIPHER_AES_128_XTS` not `GNUTLS_CIPHER_AES_256_XTS`.

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/nettle/cipher.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1648#note_1119254690

>  _xts_aes128_set_encrypt_key(struct xts_aes128_key *xts_key,

Maybe you could remove those wrapper functions.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1648
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220929/c6b06dfa/attachment.html>