[gnutls-devel] GnuTLS | Forbid uncolicited CompressedCertificate messages (!1678)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1678 was reviewed by Alexander Sosedkin

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1233883937

1. looks fixed to me
2. I see =D Yeah, looks underspecified with arguments for both contenders. OK, as of 8d71603a90 I observe `bad_certificate` and it aligns with openssl, so let's have `bad_certificate`.

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin started a new discussion on lib/tls13/certificate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1233883945

> +			if (!(session->internals.hsk_flags & HSK_COMP_CRT_REQ_SENT))
> +				return gnutls_assert_val(GNUTLS_E_UNEXPECTED_PACKET);
> +				

trailing whitespace

--
  <!-- Get preloaded note discussion-->
  
Alexander Sosedkin started a new discussion on lib/tls13/certificate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1678#note_1233883949

>  		err = _gnutls_recv_handshake(session, GNUTLS_HANDSHAKE_COMPRESSED_CERTIFICATE_PKT, 0, &buf);
>  		if (err >= 0) {
> +			/* fail if we receive unsoliceted compressed certificate */

misspelling (`s/unsoliceted/unsolicited/`), same in commit message. other occurrences look fine


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1678
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230110/a06e32be/attachment-0001.html>