[gnutls-devel] GnuTLS | tests: update tests/suite/ciphersuite after a96b04ff (!1745)

[Read-only notification of GnuTLS library development activities]

Alexander Sosedkin started a new discussion on tests/suite/ciphersuite/test-ciphers.js: https://gitlab.com/gnutls/gnutls/-/merge_requests/1745#note_1423798261

> -				console.log("Broken AEAD ciphersuite: ", kx + "-" + cipher, " ", cs.gnutlsname);
> -				process.exit(1);
> -			}
> -		} else {
> -			if (kx + "-" + cipher + "-" + mac != cs.gnutlsname) {
> -				console.log("Broken ciphersuite name: ", kx + "-" + cipher + "-" + mac, " ", cs.gnutlsname);
> -				process.exit(1);
> -			}
> -		}
> +                if (cs.min_version !== "TLS1.3") {
> +		        if (cs.mac == "AEAD") {
> +			        if (kx + "-" + cipher != cs.gnutlsname && kx + "-" + cipher + "-SHA256" != cs.gnutlsname && kx + "-" + cipher + "-SHA384" != cs.gnutlsname) {
> +				        console.log("Broken AEAD ciphersuite: ", kx + "-" + cipher, " ", cs.gnutlsname);
> +				        process.exit(1);
> +			        }
> +		        } else if (!cipher.match(/GOST/)) {

nit: maybe GOST case could benefit from having a check as well, even if it'd be just a hardcoded one

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1745#note_1423798261
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230608/0b272c86/attachment-0001.html>