[gnutls-devel] GnuTLS | Work on issue #1464 (!1720)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1720 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on tests/suite/ciphersuite/generate-registry-ciphers.py: https://gitlab.com/gnutls/gnutls/-/merge_requests/1720#note_1303327300

> +    cipher_suites = []
> +    for row in csv_reader:
> +        if row['registry_id'] == 'tls-parameters-4' and \

It now runs without failure, but the output is not as expected (I think):
```diff
 registry_ciphersuites = {
-       0x0000: "TLS_NULL_WITH_NULL_NULL",
-       0x0001: "TLS_RSA_WITH_NULL_MD5",
-       0x0002: "TLS_RSA_WITH_NULL_SHA",
...
+       '00,9E': 'TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 ([RFC5288])',
+       '00,9F': 'TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 ([RFC5288])',
+       '00,AA': 'TLS_DHE_PSK_WITH_AES_128_GCM_SHA256 ([RFC5487])',
}
```
A few observations:
- the format of keys is different (it should be 0x....)
- some ciphersuites are filtered out (because the script rejects ciphersuites with DTLS-OK != Y)

--
  
Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1720#note_1303327304

Previously, `gnutls-ciphers.js` was generated with `scan-gnutls.sh`, which you have rewritten as `scan-gnutls.py`. So I think what's expected here is to run `scan-gnutls.py` and generate a Python output (`gnutls-ciphers.py`).

However, `scan-gnutls.py` currently fails:
```console
$ python ./ciphersuite/scan-gnutls.py
  File "/home/ueno/devel/gnutls/tests/suite/./ciphersuite/scan-gnutls.py", line 58
    f"prf: \"{suite['prf']}\" }
    ^
SyntaxError: unterminated string literal (detected at line 58)
```


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1720
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230307/122a3c08/attachment.html>