[gnutls-devel] GnuTLS | add CRL issuer get test (!1722)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Mar 9 13:31:35 CET 2023

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1722 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on tests/crl_apis.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1722#note_1307263849

> +	assert(gnutls_x509_crl_get_issuer_dn(crl, crl_issuer, &crl_issuer_size)
> +	       == GNUTLS_E_SUCCESS);
> +	assert(memcmp(crl_issuer, issuer, strlen(crl_issuer)) == 0);

Use `memcmp` with a caution that a size mismatch may cause an out-of-bound read; maybe it should be `crl_issuer_size == issue_size && memcmp(crl_issuer, issuer, crl_issuer_size) == 0`?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1722
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230309/64428ff2/attachment.html>

More information about the Gnutls-devel mailing list