From gnutls-devel at lists.gnutls.org Fri Sep 1 21:07:03 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Sep 2023 19:07:03 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Hubert Kario (@mention me if you need reply) started a new discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540077463 > return ret; > } > > +/** > + * gnutls_privkey_export_dh_raw: > + * @key: Holds the public key > + * @p: will hold the p > + * @q: will hold the q > + * @g: will hold the g > + * @y: will hold the y > + * @x: will hold the x > + * @flags: flags from %gnutls_abstract_export_flags_t > + * > + * This function will export the DSA private key's parameters found While I cant be used for DSA, I think putting it front and centre makes it more confusing, not less -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540077463 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 1 21:07:31 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Sep 2023 19:07:31 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Hubert Kario (@mention me if you need reply) started a new discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540077797 > + * @flags: flags from %gnutls_abstract_export_flags_t > + * > + * This function will export the DSA private key's parameters found > + * in the given structure. The new parameters will be allocated using > + * gnutls_malloc() and will be stored in the appropriate datum. > + * > + * Returns: %GNUTLS_E_SUCCESS on success, otherwise a negative error code. > + * > + * Since: 3.8.2 > + **/ > +int gnutls_privkey_export_dh_raw(gnutls_privkey_t key, gnutls_datum_t *p, > + gnutls_datum_t *q, gnutls_datum_t *g, > + gnutls_datum_t *y, gnutls_datum_t *x, > + unsigned int flags) > +{ > + return gnutls_privkey_export_dsa_raw2(key, p, q, g, y, x, 0); if we drop `flags` here, shouldn't doc text explain that? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540077797 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 1 21:12:26 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Sep 2023 19:12:26 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 was reviewed by Hubert Kario (@mention me if you need reply) -- Hubert Kario (@mention me if you need reply) started a new discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540081703 > + } > + > + if (_gnutls_mpi_init_scan_nz(&key->params.params[4], x->data, is this a side-channel safe method? -- Hubert Kario (@mention me if you need reply) started a new discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1540081707 > + > + if (q) { > + if (_gnutls_mpi_init_scan_nz(&key->params.params[1], q->data, `params[0]`, `params[1]`, etc. look like magic variables to me... shouldn't those be `DH_P`, `DH_Q`, etc.? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 08:02:11 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 06:02:11 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: All discussions on merge request !1773 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 08:02:14 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 06:02:14 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 was reviewed by Daiki Ueno -- Daiki Ueno commented on a discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137443 > + * @flags: flags from %gnutls_abstract_export_flags_t > + * > + * This function will export the DSA private key's parameters found Yeah, it's a copy and paste error. Replaced with "Diffie-Hellman". -- Daiki Ueno commented on a discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137453 > + unsigned int flags) > +{ > + return gnutls_privkey_export_dsa_raw2(key, p, q, g, y, x, 0); Fixed to propagate the flags. -- Daiki Ueno commented on a discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137458 > + } > + > + if (_gnutls_mpi_init_scan_nz(&key->params.params[4], x->data, It simply maps to `mpz_import`, which I don't think constant-time; I'm not sure if we should make it so, as only the length could leak. -- Daiki Ueno commented on a discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137464 > + > + if (q) { > + if (_gnutls_mpi_init_scan_nz(&key->params.params[1], q->data, Good point; I did some further refactoring on that, also in the DSA code. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 08:02:34 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 06:02:34 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Reassigned merge request 1773 https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 Assignee changed to Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 08:02:41 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 06:02:41 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Hubert Kario (@mention me if you need reply) was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 08:46:08 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 06:46:08 +0000 Subject: [gnutls-devel] Guile-GnuTLS | no 4.0.0 release notes (#20) In-Reply-To: References: Message-ID: Issue was closed by Simon Josefsson Issue #20: https://gitlab.com/gnutls/guile/-/issues/20 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/issues/20 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 13:52:41 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 11:52:41 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Merge request !1773 was approved by Hubert Kario (@mention me if you need reply) Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 Project:Branches: dueno/gnutls:wip/dueno/ecdh-api to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Hubert Kario (@mention me if you need reply) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 13:52:50 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 11:52:50 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Hubert Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541842758 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541842758 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 21:25:16 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 19:25:16 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1542580092 Thanks for the review! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1542580092 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 21:25:25 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 19:25:25 +0000 Subject: [gnutls-devel] GnuTLS | Export the DH functionality (#894) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno via merge request !1773 (https://gitlab.com/gnutls/gnutls/-/merge_requests/1773) Issue #894: https://gitlab.com/gnutls/gnutls/-/issues/894 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/894 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 4 21:25:27 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 19:25:27 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773) In-Reply-To: References: Message-ID: Merge request !1773 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 Project:Branches: dueno/gnutls:wip/dueno/ecdh-api to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Hubert Kario (@mention me if you need reply) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 5 01:44:41 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 23:44:41 +0000 Subject: [gnutls-devel] GnuTLS | Export the DH functionality (#894) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.2 (Aug 5, 2023?Oct 15, 2023) ( https://gitlab.com/gnutls/gnutls/-/milestones/40 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/894 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 5 01:44:48 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 23:44:48 +0000 Subject: [gnutls-devel] GnuTLS | Export the DH functionality (#894) In-Reply-To: References: Message-ID: Reassigned Issue 894 https://gitlab.com/gnutls/gnutls/-/issues/894 Assignee changed to Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/894 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 5 01:45:44 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Sep 2023 23:45:44 +0000 Subject: [gnutls-devel] GnuTLS | Support for AES-GCM-SIV (#1356) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.2 (Aug 5, 2023?Oct 15, 2023) ( https://gitlab.com/gnutls/gnutls/-/milestones/40 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1356 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 6 07:52:26 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Sep 2023 05:52:26 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 Project:Branches: dueno/gnutls:wip/dueno/nettle-siv-gcm to gnutls/gnutls:master Author: Daiki Ueno This adds a couple of new cipher algorithms `GNUTLS_CIPHER_AES_128_SIV_GCM` and `GNUTLS_CIPHER_AES_256_SIV_GCM`, exposing `nettle_siv_gcm_aes{128,256}*` functions. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [x] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 7 02:33:32 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 00:33:32 +0000 Subject: [gnutls-devel] =?utf-8?b?R251VExTIHwgW09mZmljaWFs4oSiIV1BbGV4?= =?utf-8?q?ander_Zverev_vs_Carlos_Alcaraz_Live_Free_Coverage_ON_TV_Channel?= =?utf-8?q?_6_September_2023_=28=231500=29?= References: Message-ID: tfyguiy rtyfgiujduyf created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1500 Carlos Alcaraz vs Alexander Zverev Live US open Tennis 2023 Free TV Broadcast. In the scintillating heat of a late summer day at the 2023 US Open, fans gathered at the hallowed grounds of the USTA Billie Jean King National Tennis Center, eager to witness a clash between youth and experience. It was a match between the rising Spanish star Carlos Alcaraz and the seasoned British player Madison Zverev. **??GO LIVE??Carlos Alcaraz vs Alexander Zverev LIVE** **???STREAMING TV ???US Open 2023 Tennis LIVE** The atmosphere was electric as the two players stepped onto the hardcourt of Arthur Ashe Stadium. Carlos Alcaraz, at just 19 years old, was already making waves in the tennis world with his raw power and fearless play. Madison Zverev, a crafty veteran, brought a wealth of experience and a bag of tricks to the court. The first set showcased the exuberance of youth as Alcaraz unleashed blistering forehands and raced around the court with boundless energy. Zverev, known for his tactical acumen and deft touch, tried to counter the young Spaniard's power with his trademark slices and well-placed serves. The set went back and forth, but it was Alcaraz who managed to break Zverev' serve to take the opening set. Zverev, undeterred by the setback, showcased his veteran savvy in the second set. He mixed up his shots beautifully, keeping Alcaraz off balance. The British player's deft drop shots and clever net play earned him the second set, leveling the match. The third set was a pivotal moment in the contest. Alcaraz's relentless aggression and fearless shot-making were on full display. With the crowd firmly behind him, he surged ahead, taking the set with a series of stunning winners. The fourth set was a test of endurance and mental fortitude. Both players dug deep, knowing that a spot in the next round of the US Open was at stake. The rallies were grueling, and each point was a battle. It was Zverev who managed to outlast the young Spaniard, taking the fourth set to force a decider. As the fifth set began, the tension was palpable. Alcaraz's powerful strokes and youthful exuberance clashed with Zverev' tactical brilliance and composure. The match hung in the balance, and the crowd was treated to a tennis spectacle. In the end, it was Carlos Alcaraz who prevailed in the fifth set, unleashing a barrage of winners to secure his place in the next round. The young Spaniard's talent and fearlessness had triumphed over the wily experience of Madison Zverev. As the two players shook hands at the net, they exchanged words of mutual respect. The crowd, appreciative of the thrilling tennis they had witnessed, gave both competitors a standing ovation. Carlos Alcaraz had announced his arrival on the big stage, while Madison Zverev had once again shown that he was a force to be reckoned with. The Carlos Alcaraz vs. Madison Zverev match at the 2023 US Open would be remembered as a classic example of the generational battle that often defines tennis. It was a match filled with drama, skill, and sportsmanship, leaving fans eager to see what the future held for these two talented players. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1500 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 7 09:26:55 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 07:26:55 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Jakub Jelen was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 7 09:31:35 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 07:31:35 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1546721269 The CI failure is caused by `-Werror -Wcast-align=strict`; as we already have an alignment check on the above [line](https://git.lysator.liu.se/nettle/nettle/-/blob/95fa09b7625aefde380723ef62f6861d9736665f/ctr16.c#L55), it should be safely suppressed with an explicit (void *) cast. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1546721269 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 7 13:08:54 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 11:08:54 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Jakub Jelen commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1547140111 Did not notice any issues! I do not seem to be able to provide formal approval so approving in comments. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1547140111 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 7 19:38:01 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 17:38:01 +0000 Subject: [gnutls-devel] Guile-GnuTLS | Check the anonymous hello-world client/server example (!23) In-Reply-To: References: Message-ID: Skyler Ferris commented on a discussion: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1548054718 Hi Simon, sorry I didn't see this earlier. To clarify, the changes in the commit hat is part of this merge request (https://gitlab.com/gnutls/guile/-/merge_requests/23/diffs?commit_id=3f505f18d439271c978d9340ec0364d71ea4eb91) is identical to the diff in the issue I opened (https://gitlab.com/gnutls/guile/-/issues/16). So I saw Viven's commit creation as attributing accurately through git, not as falsifying anything. It would be appropriate to add some note like "commit prepared by Vivien Kraus", or whatever their preferred attribution would be. Let me know if you have any other concerns. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1548054718 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 8 00:26:37 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 22:26:37 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1548441935 Thank you for the review! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774#note_1548441935 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 8 00:27:40 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 22:27:40 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Merge request !1774 was set to auto-merge by Daiki Ueno Merge request url: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 Project:Branches: dueno/gnutls:wip/dueno/nettle-siv-gcm to gnutls/gnutls:master Author: Daiki Ueno Assignees: Reviewer: Jakub Jelen -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 8 00:29:45 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 22:29:45 +0000 Subject: [gnutls-devel] GnuTLS | Support for AES-GCM-SIV (#1356) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno via merge request !1774 (https://gitlab.com/gnutls/gnutls/-/merge_requests/1774) Issue #1356: https://gitlab.com/gnutls/gnutls/-/issues/1356 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1356 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Sep 8 00:29:44 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Sep 2023 22:29:44 +0000 Subject: [gnutls-devel] GnuTLS | nettle: expose SIV-GCM through the AEAD interface (!1774) In-Reply-To: References: Message-ID: Merge request !1774 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 Project:Branches: dueno/gnutls:wip/dueno/nettle-siv-gcm to gnutls/gnutls:master Author: Daiki Ueno Reviewer: Jakub Jelen -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1774 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Sep 10 23:31:43 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 10 Sep 2023 21:31:43 +0000 Subject: [gnutls-devel] Guile-GnuTLS | Check the anonymous hello-world client/server example (!23) In-Reply-To: References: Message-ID: Skyler Ferris commented on a discussion: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1552257039 Actually, it looks like it's possible to set the author and committer information separately directly in git. This would probably be the best way to make the distinction: https://git-scm.com/docs/git-commit#_commit_information -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1552257039 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Sep 10 23:34:54 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 10 Sep 2023 21:34:54 +0000 Subject: [gnutls-devel] Guile-GnuTLS | Check the anonymous hello-world client/server example (!23) In-Reply-To: References: Message-ID: Vivien Kraus Would Rather Not Be On Gitlab_com commented on a discussion: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1552257747 I think this is precisely what I did: you get authorship, I get commitership. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/merge_requests/23#note_1552257747 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 00:27:50 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 10 Sep 2023 22:27:50 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 Project:Branches: dueno/gnutls:wip/dueno/ecdh-api2 to gnutls/gnutls:master Author: Daiki Ueno This makes use of `gnutls_dh_params_t` in the signatures of the export/import functions, to avoid unnecessary serialization and deserialization of bignums. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [x] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [x] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 08:03:50 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 06:03:50 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1552451739 Note that while this changes API, it only touches the new API added in !1773 and never part of any release. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1552451739 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 11:22:41 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 09:22:41 +0000 Subject: [gnutls-devel] GnuTLS | cipher: fix AES-SIV-GCM key lengths (!1776) References: Message-ID: Miroslav Lichvar created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 Project:Branches: mlichvar/gnutls:gcm-key-length to gnutls/gnutls:master Author: Miroslav Lichvar Add a description of the new feature/bug fix. Reference any relevant bugs. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 14:28:48 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 12:28:48 +0000 Subject: [gnutls-devel] GnuTLS | cipher: fix AES-SIV-GCM key lengths (!1776) In-Reply-To: References: Message-ID: Merge request !1776 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 Project:Branches: mlichvar/gnutls:gcm-key-length to gnutls/gnutls:master Author: Miroslav Lichvar Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 14:29:16 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 12:29:16 +0000 Subject: [gnutls-devel] GnuTLS | cipher: fix AES-SIV-GCM key lengths (!1776) In-Reply-To: References: Message-ID: Merge request !1776 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 Project:Branches: mlichvar/gnutls:gcm-key-length to gnutls/gnutls:master Author: Miroslav Lichvar -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 14:29:10 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 12:29:10 +0000 Subject: [gnutls-devel] GnuTLS | cipher: fix AES-SIV-GCM key lengths (!1776) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776#note_1553041485 Good catch; thanks! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1776#note_1553041485 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 11 16:42:24 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 11 Sep 2023 14:42:24 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 was reviewed by Ondrej Moris -- Ondrej Moris started a new discussion on lib/pubkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1553306654 > + > + if (params) { > + } This looks odd, didn't you forget to implement this part? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 07:48:00 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 05:48:00 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on lib/pubkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554337602 > + int ret; > + mpi_dprint_func dprint = _gnutls_mpi_dprint_lz; > + > + if (flags & GNUTLS_EXPORT_FLAG_NO_LZ) > + dprint = _gnutls_mpi_dprint; > + > + if (key == NULL) { > + return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST); > + } > + > + if (key->params.algo != GNUTLS_PK_DH) { > + return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST); > + } > + > + if (params) { > + } Oops; seems like I removed the code block mistakenly. I've added it back and also added tests that exercise this. Thank you for spotting it! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554337602 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 07:48:00 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 05:48:00 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: All discussions on merge request !1775 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 08:25:39 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 06:25:39 +0000 Subject: [gnutls-devel] GnuTLS | 3.8.1: test suite is failing in `srp` unit (#1501) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1501#note_1554367847 Try !1772. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1501#note_1554367847 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 09:43:57 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 07:43:57 +0000 Subject: [gnutls-devel] Guile-GnuTLS | Rehandshake handling (#24) References: Message-ID: Michael Stolovitzsky created an issue: https://gitlab.com/gnutls/guile/-/issues/24 I have a blackbox API server that insists on issuing a TLS rehandshake request early into the request. `gnutls_record_recv()` returns `E_REHANDSHAKE` which gnutls-guile throws back to userland as an exception. Since the end user operates on a higher level API such as `http-request`, the userland ends up being `(web request)`. If I understand the logic correctly, gnutls-guile (being the client of gnutls) should implement the mechanism to discover and execute the rehandshake and then retry the recv call, which probably means the TLS wrapping (and `(web request)` in Guile itself) should be modified to accept an option to control whether rehandshakes are allowed. I can probably implement this myself, however I want to make sure that my logic is sound and I'm not missing any subtle detail. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/issues/24 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 10:45:07 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 08:45:07 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Ondrej Moris commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554606891 I reviewed the changes with reviewer's checklist in mind and everything seems to be in order now. Thanks you, Daiki. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554606891 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 11:31:10 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 09:31:10 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Merge request !1775 was set to auto-merge by Daiki Ueno Merge request url: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 Project:Branches: dueno/gnutls:wip/dueno/ecdh-api2 to gnutls/gnutls:master Author: Daiki Ueno Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 11:31:44 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 09:31:44 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554714619 Thank you for the review, Ondrej! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775#note_1554714619 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 12 11:46:15 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Sep 2023 09:46:15 +0000 Subject: [gnutls-devel] GnuTLS | abstract: simplify DH key export and import API (!1775) In-Reply-To: References: Message-ID: Merge request !1775 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 Project:Branches: dueno/gnutls:wip/dueno/ecdh-api2 to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1775 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Sep 17 16:37:45 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 17 Sep 2023 14:37:45 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typos found by codespell (!1777) References: Message-ID: Dimitri Papadopoulos Orfanos created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 Project:Branches: DimitriPapadopoulos/gnutls:codespell to gnutls/gnutls:master Author: Dimitri Papadopoulos Orfanos ## Checklist * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [X] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 18 11:17:18 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 18 Sep 2023 09:17:18 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typos found by codespell (!1777) In-Reply-To: References: Message-ID: Merge request !1777 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 Project:Branches: DimitriPapadopoulos/gnutls:codespell to gnutls/gnutls:master Author: Dimitri Papadopoulos Orfanos Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 18 11:17:26 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 18 Sep 2023 09:17:26 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typos found by codespell (!1777) In-Reply-To: References: Message-ID: Merge request !1777 was set to auto-merge by Daiki Ueno Merge request url: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 Project:Branches: DimitriPapadopoulos/gnutls:codespell to gnutls/gnutls:master Author: Dimitri Papadopoulos Orfanos Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 18 11:17:31 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 18 Sep 2023 09:17:31 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typos found by codespell (!1777) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777#note_1562998315 Thank you! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777#note_1562998315 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 18 11:32:10 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 18 Sep 2023 09:32:10 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typos found by codespell (!1777) In-Reply-To: References: Message-ID: Merge request !1777 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 Project:Branches: DimitriPapadopoulos/gnutls:codespell to gnutls/gnutls:master Author: Dimitri Papadopoulos Orfanos -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1777 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 18 18:59:50 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 18 Sep 2023 16:59:50 +0000 Subject: [gnutls-devel] GnuTLS | The GNUTLS Release 3.6.16 has a bug in the DTLS Non-Blocking logic, bug located at gnutls-3.6.16/lib/record.c in function _gnutls_recv_in_buffers at lines 1307 and 1322 (#1413) In-Reply-To: References: Message-ID: Andy Zhang commented: https://gitlab.com/gnutls/gnutls/-/issues/1413#note_1563780732 Hi, are there any updates on this issue? Thanks. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1413#note_1563780732 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Sep 19 11:50:25 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 19 Sep 2023 09:50:25 +0000 Subject: [gnutls-devel] Guile-GnuTLS | Segfault in `scm_gnutls_session_record_port` (#23) In-Reply-To: References: Message-ID: civodul commented on a discussion: https://gitlab.com/gnutls/guile/-/issues/23#note_1564762852 Session record ports keep a reference to their session (see `SCM_GNUTLS_SESSION_RECORD_PORT_SESSION` in `src/core.c`). Therefore, if a session record port is live, the corresponding session is also live. Do you have a backtrace we could look at? (One without debugging symbols would be better than nothing, but see https://guix.gnu.org/manual/en/html_node/Installing-Debugging-Files.html.) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/issues/23#note_1564762852 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 20 01:22:09 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 19 Sep 2023 23:22:09 +0000 Subject: [gnutls-devel] GnuTLS | 3.8.1: test suite is failing in `srp` unit (#1501) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno Issue #1501: https://gitlab.com/gnutls/gnutls/-/issues/1501 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1501 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 20 01:22:08 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 19 Sep 2023 23:22:08 +0000 Subject: [gnutls-devel] GnuTLS | 3.8.1: test suite is failing in `srp` unit (#1501) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1501#note_1565878252 Feel free to reopen if the problem still persists after applying !1772. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1501#note_1565878252 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 23 08:54:38 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 23 Sep 2023 06:54:38 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 Project:Branches: dueno/gnutls:wip/dueno/edwards-keygen to gnutls/gnutls:master Author: Daiki Ueno Previouly we used the CKM_EDDSA mechanism to generate key pair, though the mechanism can only be used for signing and verification as specified in PKCS#11 3.1 section 6.3. For key generation, the CKM_EC_EDWARDS_KEY_PAIR_GEN mechanism (or CKM_EC_MONTGOMERY_KEY_PAIR_GEN, if the point is represented in the Montgomery form) needs to be used. Fixes: #1309 ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [x] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 23 08:54:56 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 23 Sep 2023 06:54:56 +0000 Subject: [gnutls-devel] GnuTLS | p11tool cannot generate ed25519 keys (#1309) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.2 (Aug 5, 2023?Oct 15, 2023) ( https://gitlab.com/gnutls/gnutls/-/milestones/40 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1309 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 23 08:55:31 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 23 Sep 2023 06:55:31 +0000 Subject: [gnutls-devel] GnuTLS | p11tool cannot generate ed25519 keys (#1309) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1309#note_1574144578 Thank you for the report; indeed. !1778 should fix the issue. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1309#note_1574144578 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 23 08:56:19 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 23 Sep 2023 06:56:19 +0000 Subject: [gnutls-devel] GnuTLS | p11tool cannot generate ed25519 keys (#1309) In-Reply-To: References: Message-ID: Reassigned Issue 1309 https://gitlab.com/gnutls/gnutls/-/issues/1309 Assignee changed to Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1309 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Sep 24 01:19:46 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 23 Sep 2023 23:19:46 +0000 Subject: [gnutls-devel] GnuTLS | Support use of Ed448 in PKCS#11 interface (#1502) References: Message-ID: Daiki Ueno created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1502 SoftHSM supports Ed448 as well as Ed25519 when compiled with newer OpenSSL which supports the signature algorithm, though GnuTLS currently only supports Ed25519. It might make sense to extend it to cover Ed448 as well. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1502 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Sep 24 03:10:14 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 24 Sep 2023 01:10:14 +0000 Subject: [gnutls-devel] GnuTLS | Support DH and ECDH key generation in certtool (#1503) References: Message-ID: Daiki Ueno created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1503 certtool currently supports only `x25519` and `x448` key types for generating ECDH keys. Now that we added API to deal with ECDH and DH keys (#894), it might make sense to extend the support for generic curves and (known) DH parameters. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1503 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 09:20:22 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 07:20:22 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 was reviewed by Zolt?n Fridrich -- Zolt?n Fridrich started a new discussion on tests/pkcs11/pkcs11-privkey-generate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580005410 > #include > #include > +#include Is this include necessary? Shouldn't it be part of gnutls/pkcs11.h? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 09:20:22 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 07:20:22 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Zolt?n Fridrich commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580005421 Looks good. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580005421 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 09:20:22 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 07:20:22 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Merge request !1778 was approved by Zolt?n Fridrich Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 Project:Branches: dueno/gnutls:wip/dueno/edwards-keygen to gnutls/gnutls:master Author: Daiki Ueno Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 09:24:25 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 07:24:25 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: All discussions on merge request !1778 were resolved by Zolt?n Fridrich https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 09:24:21 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 07:24:21 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Zolt?n Fridrich commented on a discussion on tests/pkcs11/pkcs11-privkey-generate.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580011639 > #include > #include > #include > +#include nvm I guess its because of the `CKM_EC_EDWARDS_KEY_PAIR_GEN` macro -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580011639 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 10:22:16 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 08:22:16 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580102790 Thanks for the review! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778#note_1580102790 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 10:22:23 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 08:22:23 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: fix key pair generation for EdDSA (!1778) In-Reply-To: References: Message-ID: Merge request !1778 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 Project:Branches: dueno/gnutls:wip/dueno/edwards-keygen to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1778 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Sep 27 10:22:24 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 27 Sep 2023 08:22:24 +0000 Subject: [gnutls-devel] GnuTLS | p11tool cannot generate ed25519 keys (#1309) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno via merge request !1778 (https://gitlab.com/gnutls/gnutls/-/merge_requests/1778) Issue #1309: https://gitlab.com/gnutls/gnutls/-/issues/1309 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1309 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 28 10:29:01 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 28 Sep 2023 08:29:01 +0000 Subject: [gnutls-devel] GnuTLS | pkcs11: support Ed448 keys (!1779) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1779 Project:Branches: dueno/gnutls:wip/dueno/pkcs11-ed448 to gnutls/gnutls:master Author: Daiki Ueno This adds support for Ed448 keys backed by PKCS#11. To differentiate Ed448 keys from Ed25519 keys, this requires an extra logic to check CKA_EC_PARAMS when reading public keys. Fixes: #1502 ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [x] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1779 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 28 10:29:47 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 28 Sep 2023 08:29:47 +0000 Subject: [gnutls-devel] GnuTLS | Support use of Ed448 in PKCS#11 interface (#1502) In-Reply-To: References: Message-ID: Reassigned Issue 1502 https://gitlab.com/gnutls/gnutls/-/issues/1502 Assignee changed to Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1502 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 28 10:29:52 2023 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 28 Sep 2023 08:29:52 +0000 Subject: [gnutls-devel] GnuTLS | Support use of Ed448 in PKCS#11 interface (#1502) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.2 (Aug 5, 2023?Oct 15, 2023) ( https://gitlab.com/gnutls/gnutls/-/milestones/40 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1502 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: