[gnutls-devel] GnuTLS | Fix RSAES-PKCS1-v1_5 system-wide configuration (!1830)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Apr 11 15:53:20 CEST 2024

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1830 was reviewed by Daiki Ueno

Daiki Ueno started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1830#note_1857531294

> +static inline void cfg_init(struct cfg *cfg)
> +{
> +	cfg_deinit(cfg);

This assumes that `cfg` is previously initialized, right? I suggest removing this line.

Daiki Ueno started a new discussion on lib/priority.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1830#note_1857531319

> +		ret = gnutls_rwlock_wrlock(&system_wide_config_rwlock);
> +		if (ret < 0)
> +			return gnutls_assert_val(ret);

Shouldn't this be `goto out;`? Otherwise the write lock is still held.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1830
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240411/c4eab3aa/attachment-0001.html>

More information about the Gnutls-devel mailing list