[gnutls-devel] GnuTLS | Makefile.am: error if libdane missing on make dist (!1903)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Thu Dec 5 20:34:36 CET 2024
William Roberts created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1903
Project:Branches: wcrobertarm/gnutls:fix-libdane-missing-dist to gnutls/gnutls:master
Author: William Roberts
<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->
* Makefile.am: error if libdane missing on make dist
if libdane is not configured, then make dist will fail with:
make[3]: *** No rule to make target 'libdane/libgnutls-dane.la', needed by 'abi-check-latest'. Stop.
Now it will fail with:
ERROR: Distribution requires libdane, please enable libdane
Signed-off-by: Bill Roberts <bill.roberts at arm.com>
## Checklist
* [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1903
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241205/bcdc3180/attachment.html>
More information about the Gnutls-devel
mailing list