[gnutls-devel] GnuTLS | groups: represent hybrid groups with an array of IDs (!1904)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Fri Dec 6 06:57:16 CET 2024
Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904
Project:Branches: dueno/gnutls:wip/dueno/hybrid-kx-liboqs-followup2 to gnutls/gnutls:master
Author: Daiki Ueno
<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->
Previously, the supported_groups array contained externally defined
elements, which is legitimate in C99 but caused error with Clang:
```
groups.c:93:2: error: initializer element is not a compile-time constant
group_x25519,
^~~~~~~~~~~~
```
This reworks the array definition of indirection through group
IDs (gnutls_group_t, i.e., integer).
Fixes: #1604
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241206/1066d873/attachment.html>
More information about the Gnutls-devel
mailing list