[gnutls-devel] GnuTLS | groups: represent hybrid groups with an array of IDs (!1904)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1904 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on lib/algorithms/groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904#note_2248735381

 > +		return group_is_supported_standalone(group);
 > +
 > +	for (size_t i = 0; i < NUM_HYBRID_GROUPS; i++) {

I'm not sure how would this iteration work, would the limit ever be raised and uneven length `group->ids` appear.

--
  
Alexander Sosedkin started a new discussion on lib/algorithms/groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904#note_2248735393

 > -	  .tls_id = 0x11EB,
 > -	  .next = &group_mlkem768 },
 > +	  .ids = { GNUTLS_GROUP_SECP256R1, GNUTLS_GROUP_EXP_MLKEM768 },

Would it be beneficial to NULL-terminate it or store the length?

--
  
Alexander Sosedkin started a new discussion on lib/algorithms.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904#note_2248735397

 >  #endif
 >  
 > +#define IS_GROUP_HYBRID(group) ((group)->ids[0] != GNUTLS_GROUP_INVALID)

Why are we sure of it being zero-initialized?

--
  
Alexander Sosedkin started a new discussion on lib/algorithms/groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904#note_2248735400

 > +}
 > +
 > +static inline bool group_is_supported(const gnutls_group_entry_st *group)

With this definition of supportedness, how does one enable just hybrids or just non-hybrids?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1904
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241209/8047745d/attachment-0001.html>