[gnutls-devel] GnuTLS | Support RSA-OAEP (!1805)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1805 was reviewed by Zoltán Fridrich

--
  
Zoltán Fridrich started a new discussion on lib/nettle/pk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1805#note_1797176103

> +				   plaintext->data, ciphertext->data);
> +		if (ret < 0) {
> +			gnutls_assert();

should the ciphertext->data be freed on error?

--
  
Zoltán Fridrich started a new discussion on lib/nettle/pk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1805#note_1797176126

> +	ret = rsa_encrypt(key, rnd_ctx, rnd_func, length, message, p);
> +
> +	if (_gnutls_mpi_bprint_size(p, ciphertext, key->size) < 0) {

Question: Is this guaranteed to fail when rsa_encrypt fails? Or will this always succeed when rsa_encrypt succeeds?

--
  
Zoltán Fridrich started a new discussion on lib/nettle/pk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1805#note_1797176136

> +
> +		if (ret == 0 || HAVE_LIB_ERROR()) {
> +			ret = gnutls_assert_val(GNUTLS_E_DECRYPTION_FAILED);

Probably should clean up plaintext->data here as well.




-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1805
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240301/9cc99796/attachment-0001.html>