[gnutls-devel] GnuTLS | Fixed DHE params output in gnutls-cli-debug (!1822)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1822 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on src/tests.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1822#note_1891402278

 > +				       "could not be accessed.\n");
 > +				printf("***************************************************************"
 > +				       "**\033[0m\n");

It looks a bit too fancy to me :-) Maybe you could (1) print the log to stderr and (2) use `strerror` to print the cause:
```c
fprintf(stderr, "unable to open file %s: %s\n", dhparams_value, strerror(errno));
```

--
  
Daiki Ueno started a new discussion on src/tests.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1822#note_1891402291

 > +			}
 > +			fclose(fp);
 > +		} else {

The content of this `else` branch is basically a duplicate of the above `if` branch, except that the output is printed using `printf` instead of `fprintf(fp, ...)`. Maybe you could consolidate them by assigning `fp = stdout` if `--dhparams-out` is not specified?




-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1822
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240503/a22ca73a/attachment-0001.html>