[gnutls-devel] GnuTLS | Assorted fixes (!1894)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1894 was reviewed by Zoltán Fridrich

--
  
Zoltán Fridrich started a new discussion on lib/liboqs/sha3x4.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1894#note_2200973717

 > +/*
 > + * This file is part of GNUTLS.

Maybe also add the copyright line and author name?

--
  
Zoltán Fridrich started a new discussion on lib/liboqs/sha3x4.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1894#note_2200973735

 > +#include "liboqs/sha3x4.h"
 > +
 > +#include "dlwrap/oqs.h"

Includes could be sorted.

--
  
Zoltán Fridrich started a new discussion on lib/liboqs/sha3x4.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1894#note_2200973750

 > +		return;
 > +
 > +	for (size_t i = 0; i < 4; i++) {

I think we don't use the syntax of declaring vars in for loops.
I am not sure if it matters though.

--
  
Zoltán Fridrich started a new discussion on lib/liboqs/sha3x4.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1894#note_2200973763

 > +		return;
 > +
 > +	for (size_t i = 0; i < 4; i++) {

maybe better to do something similar to `sizeof(p->hds) / sizeof(p->hds[0])` rather then hard coding. Also change this in other functions.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1894
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241108/be122388/attachment-0001.html>