[gnutls-devel] GnuTLS | fips: mark sha1 as not approved for SigVer in FIPS mode (!1900)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Thu Nov 28 10:05:07 CET 2024
Angel Yankov created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1900
Project:Branches: ayankov/gnutls:fips/sha1_sigver_disable to gnutls/gnutls:master
Author: Angel Yankov
<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->
During FIPS-140-3 prep we were told that SHA-1 cannot be CAVP tested anymore. Thus, Mark it as not approved for signature verification.
Signed-off-by: Angel Yankov <angel.yankov at suse.com>
## Checklist
* [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [x] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
Note: This is just re-opening https://gitlab.com/gnutls/gnutls/-/merge_requests/1891 as it was accidentally deleted. Code should be the same, but please advise if the switch approving only SHA-2* family is correct.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1900
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241128/bf213130/attachment.html>
More information about the Gnutls-devel
mailing list