[gnutls-devel] GnuTLS | Update liboqs version requirement to 0.11.0 to support final version of ML-KEM (!1883)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Oct 10 00:31:02 CEST 2024




Daiki Ueno commented on a discussion on lib/algorithms/groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1883#note_2151245693

 > -			if ((p->curve == 0 ||
 > -			     _gnutls_ecc_curve_is_supported(p->curve)) &&
 > -			    (p->pk == 0 || _gnutls_pk_exists(p->pk)) &&
 > -			    (p->pk2 == 0 || _gnutls_pk_exists(p->pk2)))
 > -				groups[i++] = p->id;);
 > +		const gnutls_group_entry_st *p;
 > +
 > +		for (p = supported_groups; p->name != NULL; p++) {
 > +			const gnutls_group_entry_st *pp;
 > +
 > +			for (pp = p; pp != NULL; pp = pp->next) {
 > +				if ((pp->curve == 0 ||
 > +				     _gnutls_ecc_curve_is_supported(
 > +					     pp->curve)) &&
 > +				    (pp->pk == 0 || _gnutls_pk_exists(pp->pk)))
 > +					groups[i++] = pp->id;

Good catch, changed the logic to require all linked groups to match.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1883#note_2151245693
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241009/5ca4a6c4/attachment-0001.html>


More information about the Gnutls-devel mailing list