From gnutls-devel at lists.gnutls.org Wed Sep 4 12:22:03 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 04 Sep 2024 10:22:03 +0000 Subject: [gnutls-devel] GnuTLS | configure issues: syntax error during faketime detection, --without-brotli not working (#1576) References: Message-ID: Tim Kosse created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1576 Both issues observed in GnuTLS 3.8.7 1. Missing quotes around backtick expansion results in a syntax error if faketime exists but is not working): ``` ./configure: line 12286: test: =: unary operator expected ``` 2. Even with --without-brotli, the HAVE_LIBBROTLI automake conditional is still set, resulting in a compile error later on if there is no libbrotli The attached patch to configure.ac addresses both issues, please use it as you see fit. [configure.ac.diff](/uploads/f9b7e05d73c97a472402f6d129e792e4/configure.ac.diff) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1576 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Sep 5 13:14:17 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 05 Sep 2024 11:14:17 +0000 Subject: [gnutls-devel] GnuTLS | SEGFAULT in libgnutls30 during multithreaded call of `gnutls_record_send` (#1567) In-Reply-To: References: Message-ID: Moritz Schneider commented: https://gitlab.com/gnutls/gnutls/-/issues/1567#note_2091862824 @dueno Thank you for your comment! I've initialized gnuTLS with `GNUTLS_NO_AUTO_REKEY` and since then I've seen no SEGFAULT yet. So I guess we can close this issue. If I will see a SEGFAULT again ? which I currently not expect ? I can reopen this issue. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1567#note_2091862824 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 7 13:57:06 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 07 Sep 2024 11:57:06 +0000 Subject: [gnutls-devel] GnuTLS | Draft: Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Andreas Metzler commented on a discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2095005634 > [[void *handle = dlopen("$M_LIBRARY_SONAME", RTLD_LAZY | RTLD_GLOBAL); > return handle != NULL ? 0 : 1; > ]])], > - [ac_cv_dlopen_soname_works=yes], > - [ac_cv_dlopen_soname_works=no], > + [ac_cv_dlopen_soname_works=yes] > + [AC_MSG_RESULT(yes)], OK -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2095005634 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 7 13:57:06 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 07 Sep 2024 11:57:06 +0000 Subject: [gnutls-devel] GnuTLS | Draft: Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: All discussions on merge request !1870 were resolved by Andreas Metzler https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 7 14:12:15 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 07 Sep 2024 12:12:15 +0000 Subject: [gnutls-devel] GnuTLS | Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Andreas Metzler marked merge request !1870 as ready -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Sep 7 17:39:26 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 07 Sep 2024 15:39:26 +0000 Subject: [gnutls-devel] GnuTLS | configure issues: syntax error during faketime detection, --without-brotli not working (#1576) In-Reply-To: References: Message-ID: Andreas Metzler commented: https://gitlab.com/gnutls/gnutls/-/issues/1576#note_2095097246 Part 2 of the patch was superseded by !1870. I have now also integrated the first part there. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1576#note_2095097246 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 08:29:50 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 06:29:50 +0000 Subject: [gnutls-devel] GnuTLS | Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 was reviewed by Daiki Ueno -- Daiki Ueno started a new discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2095702781 > fi > -AM_CONDITIONAL(HAVE_ZLIB, test "$ac_zlib" != "no") > +AM_CONDITIONAL(HAVE_LIBZ, test "$ac_zlib" != "no") I would prefer the other way around; spell ZLIB everywhere instead of LIBZ. The only reason why it was written as LIBZ is that Gnulib's havelib module [uses](https://git.savannah.gnu.org/cgit/gnulib.git/plain/m4/lib-link.m4) that convention, though we are switching away from it. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 08:29:50 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 06:29:50 +0000 Subject: [gnutls-devel] GnuTLS | Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Merge request !1870 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870 Project:Branches: ametzler/gnutls:2024-tmp-choose-dlopen to gnutls/gnutls:master Author: Andreas Metzler Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 08:29:49 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 06:29:49 +0000 Subject: [gnutls-devel] GnuTLS | Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2095702788 Looks good to me, except a minor nit; thanks! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2095702788 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 09:16:07 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 07:16:07 +0000 Subject: [gnutls-devel] GnuTLS | SEGFAULT in libgnutls30 during multithreaded call of `gnutls_record_send` (#1567) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno Issue #1567: https://gitlab.com/gnutls/gnutls/-/issues/1567 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1567 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 09:16:06 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 07:16:06 +0000 Subject: [gnutls-devel] GnuTLS | SEGFAULT in libgnutls30 during multithreaded call of `gnutls_record_send` (#1567) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1567#note_2095770498 Thanks for confirming. Closing. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1567#note_2095770498 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Sep 9 19:54:26 2024 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 09 Sep 2024 17:54:26 +0000 Subject: [gnutls-devel] GnuTLS | Choose whether to link or dlopen helper libraries (!1870) In-Reply-To: References: Message-ID: Andreas Metzler commented on a discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2096910048 > AC_DEFINE([HAVE_LIBZ], 1, [Define if ZLIB compression is enabled.]) > need_ltlibdl=yes > fi > -AM_CONDITIONAL(HAVE_ZLIB, test "$ac_zlib" != "no") > +AM_CONDITIONAL(HAVE_LIBZ, test "$ac_zlib" != "no") I flipped a coin ... the wrong way. ;-) Will change. ZLIB is a little bit nicer indeed, `grep HAVE_ZLIB` will not match HAVE_LIBZSTD like HAVE_LIBZ did. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1870#note_2096910048 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: