[gnutls-devel] GnuTLS | nettle: fail OAEP decryption on unknown hash (!1876)

[Read-only notification of GnuTLS library development activities]

Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1876

Project:Branches: asosedkin/gnutls:oaep-unkn-hash to gnutls/gnutls:master
Author:   Alexander Sosedkin




nettle: fail OAEP decryption on unknown hash

_rsa_oaep_decrypt() "returns 1 on success; 0 otherwise",
but here we've returned non-zero on using an unsupported hash.
This confused the error reporting into thinking gnutls_privkey_decrypt_data()
has succeeded, while it hasn't.

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1876
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240920/400e2165/attachment.html>