From gnutls-devel at lists.gnutls.org Fri Aug 1 00:52:59 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 31 Jul 2025 22:52:59 +0000 Subject: [gnutls-devel] GnuTLS | build: check if Esys_SetCryptoCallbacks is available (!1996) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996 Project:Branches: dueno/gnutls:wip/devkdas/esys-crypto-callback to gnutls/gnutls:master Author: Daiki Ueno * build: check if Esys_SetCryptoCallbacks is available Fixes: #1724 ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 00:54:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 31 Jul 2025 22:54:37 +0000 Subject: [gnutls-devel] GnuTLS | Fix for 1724 (!1988) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2662999889 Thank you Karthik, a new MR has been filed for merge (!1996). -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2662999889 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 00:54:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 31 Jul 2025 22:54:37 +0000 Subject: [gnutls-devel] GnuTLS | Fix for 1724 (!1988) In-Reply-To: References: Message-ID: Merge request !1988 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988 Project:Branches: devkdas/gnutls:fix-#1724 to gnutls/gnutls:master Author: Karthik Das Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 04:54:13 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 02:54:13 +0000 Subject: [gnutls-devel] GnuTLS | Fix for 1724 (!1988) In-Reply-To: References: Message-ID: Karthik Das commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2663146296 https://gitlab.com/gnutls/gnutls/-/merge_requests/1996 I see. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2663146296 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 07:29:24 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 05:29:24 +0000 Subject: [gnutls-devel] GnuTLS | Not able to build gnutls on ubuntu 22 (#1724) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno with merge request !1996 (https://gitlab.com/gnutls/gnutls/-/merge_requests/1996) Issue #1724: https://gitlab.com/gnutls/gnutls/-/issues/1724 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1724 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 07:29:23 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 05:29:23 +0000 Subject: [gnutls-devel] GnuTLS | build: check if Esys_SetCryptoCallbacks is available (!1996) In-Reply-To: References: Message-ID: Merge request !1996 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996 Project:Branches: dueno/gnutls:wip/devkdas/esys-crypto-callback to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 07:34:19 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 05:34:19 +0000 Subject: [gnutls-devel] GnuTLS | build: check if Esys_SetCryptoCallbacks is available (!1996) In-Reply-To: References: Message-ID: Karthik Das commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996#note_2663271283 Thanks @dueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1996#note_2663271283 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 11:58:10 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 09:58:10 +0000 Subject: [gnutls-devel] GnuTLS | gnutls_session_t unsafe to use from multiple threads due to TLS 1.3 rekeying (#1717) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno with merge request !1990 (https://gitlab.com/gnutls/gnutls/-/merge_requests/1990) Issue #1717: https://gitlab.com/gnutls/gnutls/-/issues/1717 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1717 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 12:36:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 10:36:16 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) References: Message-ID: chenjianhu created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 Project:Branches: cjhxmx/gnutls:gnutls-pr to gnutls/gnutls:master Author: chenjianhu * X509:Fix incorrect handling in name constraints merging As mentioned in commit ca573d65 ("x509: Fix asymmetry in name constraints intersection", 2016-07-29), the _gnutls_name_constraints_intersect function exhibited an asymmetry in name constraints intersection behavior, specifically manifested as: 1. Nodes of unique types in PERMITTED (absent in PERMITTED2) were preserved 2. Nodes of unique types in PERMITTED2 (absent in PERMITTED) were discarded A 'used' flag was introduced, where if a node from PERMITTED2 was not used for the intersection, it would be copied to PERMITTED. However,an unresolved edge case persisted: - When 'removed.size > 0', the 'used' flag was unconditionally set to 1 - This prevented copying of PERMITTED2 nodes with unique types Signed-off-by: chenjianhu -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 16:19:28 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 14:19:28 +0000 Subject: [gnutls-devel] GnuTLS | lib/nettle/pk.c: Add check for gnutls_malloc() (!1986) In-Reply-To: References: Message-ID: Merge request !1986 was reopened by Jiasheng Jiang Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1986 Project:Branches: purdue-university1/gnutls:patch21 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1986 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 1 16:19:45 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 01 Aug 2025 14:19:45 +0000 Subject: [gnutls-devel] GnuTLS | lib/nettle/pk.c: Add check for gnutls_malloc() (!1986) In-Reply-To: References: Message-ID: Merge request !1986 was closed by Jiasheng Jiang Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1986 Project:Branches: purdue-university1/gnutls:patch21 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1986 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 2 17:44:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 15:44:11 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 Project:Branches: purdue-university1/gnutls:patch22 to gnutls/gnutls:master Author: Jiasheng Jiang * lib/anon_cred.c: Add check for gnutls_calloc According to the comment above, add check for the return value of gnutls_calloc() and return an error code if it fails. Fixes: 23efd9990 ("The Diffie Hellman parameters are now stored in the credentials structures. This will allow precomputation of signatures (for DHE cipher suites).") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 2 17:51:51 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 15:51:51 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_dn.c: Add check for gnutls_calloc (!1999) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999 Project:Branches: purdue-university1/gnutls:patch23 to gnutls/gnutls:master Author: Jiasheng Jiang * lib/x509/x509_dn.c: Add check for gnutls_calloc Add check for the return value of gnutls_calloc() to avoid potential NULL pointer dereference. Fixes: 6c9dadf6c ("Moved the gnutls_x509_dn API functions to x509_dn.c") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 2 18:07:00 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 16:07:00 +0000 Subject: [gnutls-devel] GnuTLS | lib/pkcs11_privkey.c: Add check for gnutls_malloc (!2000) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000 Project:Branches: purdue-university1/gnutls:patch24 to gnutls/gnutls:master Author: Jiasheng Jiang * lib/pkcs11_privkey.c: Add check for gnutls_malloc Add check for the return value of gnutls_malloc() to avoid potential NULL pointer dereference. Fixes: be560a813 ("Added gnutls_pkcs11_privkey_t and gnutls_privkey_t types. Those are an abstract private key type that can be used to sign/encrypt any private key of pkcs11,x509 or openpgp types. Added support for PKCS11 in gnutls-cli/gnutls-serv.") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 2 23:16:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 21:16:16 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 Project:Branches: purdue-university1/gnutls:patch26 to gnutls/gnutls:master Author: Jiasheng Jiang * tests/suite/mini-record-timing.c: Add check for gnutls_malloc Add check for the return value of gnutls_malloc() to avoid potential NULL pointer dereference. Fixes: 75363e1f2 ("cbc-record-check.sh: introduced") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 2 23:17:32 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 21:17:32 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 Project:Branches: purdue-university1/gnutls:patch25 to gnutls/gnutls:master Author: Jiasheng Jiang * src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup Add check for the return value of gnutls_malloc() and gnutls_strdup() to avoid potential NULL pointer dereference. Fixes: 44541d171 ("p11tool: copy vendor query attributes when listing privkeys") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 01:11:01 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 02 Aug 2025 23:11:01 +0000 Subject: [gnutls-devel] GnuTLS | tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference (!2003) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003 Project:Branches: purdue-university1/gnutls:patch27 to gnutls/gnutls:master Author: Jiasheng Jiang * tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference Add check for the return value of gnutls_malloc() to avoid potential NULL pointer dereference. Fixes: 4fe788cc1 ("psk: Add basic support for RFC 9258 external PSK importer interface") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:47:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:47:56 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2665231588 @cjhxmx thank you, the change makes sense to me. Do you happen to have a reproducer to exercise the corner case? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2665231588 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:54:31 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:54:31 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 was reviewed by Daiki Ueno -- Daiki Ueno started a new discussion on src/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665232389 > + fprintf(stderr, "memory error\n"); > + gnutls_free(output); > + continue; I would suggest aborting here with `app_exit(1)`, as the following logic wouldn't work without `objurl`. -- Daiki Ueno started a new discussion on src/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665232398 > + fprintf(stderr, "memory error\n"); > + gnutls_free(output); > + continue; Same as above, let's just exit. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:57:04 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:57:04 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 was reviewed by Daiki Ueno -- Daiki Ueno started a new discussion on tests/suite/mini-record-timing.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001#note_2665232742 > key->data = gnutls_malloc(4); > + if (key->data == NULL) { > + return GNUTLS_E_MEMORY_ERROR; The documentation says: ``` * The callback function will only be called once per handshake. The * callback function should return 0 on success, while -1 indicates * an error. ``` Return -1 (and possibly print the error), instead of `GNUTLS_E_MEMORY_ERROR`. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:58:22 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:58:22 +0000 Subject: [gnutls-devel] GnuTLS | lib/pkcs11_privkey.c: Add check for gnutls_malloc (!2000) In-Reply-To: References: Message-ID: Merge request !2000 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000 Project:Branches: purdue-university1/gnutls:patch24 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:59:05 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:59:05 +0000 Subject: [gnutls-devel] GnuTLS | lib/pkcs11_privkey.c: Add check for gnutls_malloc (!2000) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000#note_2665233028 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000#note_2665233028 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:59:50 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:59:50 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_dn.c: Add check for gnutls_calloc (!1999) In-Reply-To: References: Message-ID: Merge request !1999 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999 Project:Branches: purdue-university1/gnutls:patch23 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 03:59:58 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 01:59:58 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_dn.c: Add check for gnutls_calloc (!1999) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999#note_2665233143 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999#note_2665233143 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 04:01:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 02:01:18 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Merge request !1998 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 Project:Branches: purdue-university1/gnutls:patch22 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 04:01:26 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 02:01:26 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665233372 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665233372 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 06:47:15 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 04:47:15 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Andreas Metzler commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665261726 @JiashengJiang Thank you! Having one merge request for each of a number of similar two-line changes is terribly noisy on the gnutls-dev list. Could you bundle stuff like this in one merge request (with multiple commits or a single one if they match a single theme) in the future? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665261726 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 20:54:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 18:54:18 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Jiasheng Jiang commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665532593 I?m really sorry for the noise I caused on the gnutls-dev list. Thank you for pointing it out ? I?ll make sure to bundle similar changes into a single merge request in the future, either with multiple commits or one, depending on the theme. Thanks again for your understanding! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665532593 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Aug 3 20:54:27 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 18:54:27 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: All discussions on merge request !1998 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 00:41:49 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 03 Aug 2025 22:41:49 +0000 Subject: [gnutls-devel] GnuTLS | Urgent Contact Request Regarding DHCP Access Behavior (#1728) References: Message-ID: Oscar Barrera created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1728 Dear Nikos, I'm reaching out regarding a message that appeared to reference a DHCP access modification for MAC-based packet filtering and sandbox control. It included your name and contact address (nmav at gennetsa.com), but our attempt to reach you via that channel was blocked (550 5.4.1 access denied). Given the serious nature of the technical signals we?ve detected ? especially concerning unauthorized digital interference and MAC-based relay anomalies ? we are respectfully asking if you are aware of any public code or relay behavior linked to AppConduit, tokenizer_trace, or dhcp-script sandbox triggers. This is part of an urgent digital forensic investigation involving the safety of a minor, and your work may help us confirm whether this mechanism was misused or repurposed. We would also like to request your **GPG public key** for encrypted follow-up. You can reply here or via a secure email if preferred. Thank you for your time, and for any help you may be able to provide. Respectfully, Oscar A. Santos Barrera (on behalf of legal guardianship team) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1728 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:19:32 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:19:32 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Jiasheng Jiang commented on a discussion on src/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665626201 > if (vendor) { > objurl = gnutls_malloc(strlen(output) + strlen(vendor) + > 1); > + if (objurl == NULL) { > + fprintf(stderr, "memory error\n"); > + gnutls_free(output); > + continue; Thank you. I have fixed it. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665626201 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:19:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:19:37 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: All discussions on merge request !2002 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:19:49 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:19:49 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Jiasheng Jiang commented on a discussion on src/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665626370 > objurl = gnutls_malloc(strlen(output) + strlen(vendor) + > 1); > + if (objurl == NULL) { > + fprintf(stderr, "memory error\n"); > + gnutls_free(output); > + continue; > + } > + > strcpy(objurl, output); > strcat(objurl, vendor); > } else { > objurl = gnutls_strdup(output); > + if (objurl == NULL) { > + fprintf(stderr, "memory error\n"); > + gnutls_free(output); > + continue; Thank you. I have fixed it. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665626370 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:19:51 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:19:51 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: All discussions on merge request !2002 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:47:42 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:47:42 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: All discussions on merge request !2001 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 02:47:43 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 00:47:43 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: Jiasheng Jiang commented on a discussion on tests/suite/mini-record-timing.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001#note_2665636524 > gnutls_datum_t *key) > { > key->data = gnutls_malloc(4); > + if (key->data == NULL) { > + return GNUTLS_E_MEMORY_ERROR; Thank you. I have fixed it. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001#note_2665636524 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 03:38:42 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 01:38:42 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Merge request !2002 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 Project:Branches: purdue-university1/gnutls:patch25 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 03:39:01 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 01:39:01 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: Merge request !2001 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 Project:Branches: purdue-university1/gnutls:patch26 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 06:02:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 04:02:37 +0000 Subject: [gnutls-devel] GnuTLS | tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference (!2003) In-Reply-To: References: Message-ID: Merge request !2003 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003 Project:Branches: purdue-university1/gnutls:patch27 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 06:02:50 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 04:02:50 +0000 Subject: [gnutls-devel] GnuTLS | tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference (!2003) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003#note_2665733666 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003#note_2665733666 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:12:36 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:12:36 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!2004) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004 Project:Branches: dueno/gnutls:wip/purdue-university1/malloc-check to gnutls/gnutls:master Author: Daiki Ueno This MR includes the following fixes from !1998, !1999, !2000, !2001, !2002, and !2003, cloned for CI purposes. * tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference * src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup * tests/suite/mini-record-timing.c: Add check for gnutls_malloc * lib/pkcs11_privkey.c: Add check for gnutls_malloc * lib/x509/x509_dn.c: Add check for gnutls_calloc * lib/anon_cred.c: Add check for gnutls_calloc ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:18 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Merge request !1998 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 Project:Branches: purdue-university1/gnutls:patch22 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:19 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:19 +0000 Subject: [gnutls-devel] GnuTLS | lib/anon_cred.c: Add check for gnutls_calloc (!1998) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665782672 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1998#note_2665782672 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:44 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:44 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_dn.c: Add check for gnutls_calloc (!1999) In-Reply-To: References: Message-ID: Merge request !1999 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999 Project:Branches: purdue-university1/gnutls:patch23 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:53 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:53 +0000 Subject: [gnutls-devel] GnuTLS | lib/pkcs11_privkey.c: Add check for gnutls_malloc (!2000) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000#note_2665783085 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000#note_2665783085 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:54 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:54 +0000 Subject: [gnutls-devel] GnuTLS | lib/pkcs11_privkey.c: Add check for gnutls_malloc (!2000) In-Reply-To: References: Message-ID: Merge request !2000 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000 Project:Branches: purdue-university1/gnutls:patch24 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2000 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:06 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:06 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: Merge request !2001 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 Project:Branches: purdue-university1/gnutls:patch26 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:14:43 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:14:43 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_dn.c: Add check for gnutls_calloc (!1999) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999#note_2665782978 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1999#note_2665782978 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:06 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:06 +0000 Subject: [gnutls-devel] GnuTLS | tests/suite/mini-record-timing.c: Add check for gnutls_malloc (!2001) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001#note_2665783220 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2001#note_2665783220 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:18 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Merge request !2002 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 Project:Branches: purdue-university1/gnutls:patch25 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:25 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:25 +0000 Subject: [gnutls-devel] GnuTLS | tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference (!2003) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003#note_2665783536 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003#note_2665783536 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:17 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:17 +0000 Subject: [gnutls-devel] GnuTLS | src/pkcs11.c: Add check for gnutls_malloc and gnutls_strdup (!2002) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665783371 Thank you; as we are currently facing some limitation in GitLab CI, filed a separate MR (!2004) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2002#note_2665783371 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:15:27 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:15:27 +0000 Subject: [gnutls-devel] GnuTLS | tests/psk-importer.c: Add check for gnutls_malloc to avoid potential NULL pointer dereference (!2003) In-Reply-To: References: Message-ID: Merge request !2003 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003 Project:Branches: purdue-university1/gnutls:patch27 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2003 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 07:55:08 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 05:55:08 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2665814689 Thank you for the update. May I suggest renaming the function to `gnutls_record_get_max_send_size` to be more consistent with the existing functions to access the limits? Also I'm not entirely sure about your use-case, but is it important to know if the `record_size_limit` extension is negotiated (and the limit is not from the `max_fragment_length` extension)? For that purpose, I might suggest using `gnutls_ext_raw_parse` in the handshake hook function, rather than special casing it in the accessor function. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2665814689 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 09:49:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 07:49:16 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: chenjianhu commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2665996178 I did not write a separate test case. Instead, I modified nc1 to nc2 in line 112 of tests/name-constraints-merge.c, so that nc2 contains an independent email constraint. Prior to this commit, the email constraint would not be appended to nc1, resulting in the email constraint not taking effect.In line 185 of the test case would fail validation: set_name("xxx.ccc.com", &name); ret = gnutls_x509_name_constraints_check(nc1, GNUTLS_SAN_RFC822NAME,&name); check_test_result(suite, ret, NAME_REJECTED, &name); After applying this commit, the email constraint will be appended to nc1, and the test case will meet the expected result. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2665996178 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 09:57:49 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 07:57:49 +0000 Subject: [gnutls-devel] GnuTLS | Urgent Contact Request Regarding DHCP Access Behavior (#1728) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno Issue #1728: https://gitlab.com/gnutls/gnutls/-/issues/1728 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1728 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Aug 4 09:57:51 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 04 Aug 2025 07:57:51 +0000 Subject: [gnutls-devel] GnuTLS | Urgent Contact Request Regarding DHCP Access Behavior (#1728) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1728#note_2666014599 I've forwarded this to Nikos. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1728#note_2666014599 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 03:43:48 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 01:43:48 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: All discussions on merge request !1997 were resolved by chenjianhu https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 05:18:20 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 03:18:20 +0000 Subject: [gnutls-devel] GnuTLS | Add check for gnutls_{malloc, calloc, strdup} (!2004) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004#note_2668509334 Merging this without approval, as the original MRs have already been reviewed. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004#note_2668509334 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 05:18:26 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 03:18:26 +0000 Subject: [gnutls-devel] GnuTLS | Add check for gnutls_{malloc, calloc, strdup} (!2004) In-Reply-To: References: Message-ID: Merge request !2004 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004 Project:Branches: dueno/gnutls:wip/purdue-university1/malloc-check to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2004 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 05:45:31 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 03:45:31 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Wilfred Mallawa commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2668528934 Thanks for the feedback! I have renamed the function as you suggested. To your second point, it is not essential that we know if it was the `record_size_limit` extension, but just the maximum send size to obey that the kernel will need to adhere to. So I think for now we can get away with just getting the send size. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2668528934 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 10:37:06 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 08:37:06 +0000 Subject: [gnutls-devel] GnuTLS | ext/max_record: add function to get max send size (!2005) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005 Project:Branches: dueno/gnutls:wip/twilfredo/record-size-tls-test to gnutls/gnutls:master Author: Daiki Ueno This is a clone of !1989, to exercise the CI. * ext/max_record: add function to get max send size Adds a new function to max_record library to extract the endpoints maximum record send size. Which may have been negotiated through the record_size_limit or the max_fragment_length extensions. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 10:37:25 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 08:37:25 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Merge request !1989 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989 Project:Branches: twilfredo/gnutls:wilfred/record-size-tls-test to gnutls/gnutls:master Author: Wilfred Mallawa Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 10:38:14 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 08:38:14 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2668933919 Thank you. As we are facing some limitation in CI, I've created a separate MR (!2005) to merge this. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2668933919 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 10:38:15 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 08:38:15 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Merge request !1989 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989 Project:Branches: twilfredo/gnutls:wilfred/record-size-tls-test to gnutls/gnutls:master Author: Wilfred Mallawa Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 12:40:25 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 10:40:25 +0000 Subject: [gnutls-devel] GnuTLS | ext/max_record: add function to get max send size (!2005) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005#note_2669253466 Merging this without approval, as the original MR has already been reviewed. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005#note_2669253466 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 12:50:40 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 10:50:40 +0000 Subject: [gnutls-devel] GnuTLS | ext/max_record: add function to get max send size (!2005) In-Reply-To: References: Message-ID: Merge request !2005 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005 Project:Branches: dueno/gnutls:wip/twilfredo/record-size-tls-test to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2005 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 16:14:39 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 14:14:39 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 Project:Branches: purdue-university1/gnutls:patch28 to gnutls/gnutls:master Author: Jiasheng Jiang * Add check for memory allocation APIs to avoid NULL pointer dereference Add check for the return value of memory allocation APIs to avoid NULL pointer dereference. Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 16:21:57 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 14:21:57 +0000 Subject: [gnutls-devel] GnuTLS | tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak (!2007) References: Message-ID: Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007 Project:Branches: purdue-university1/gnutls:patch29 to gnutls/gnutls:master Author: Jiasheng Jiang * tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak Add gnutls_free() to free p if error occurs to avoid memory leak. Fixes: b167cc373 ("tests: added checks on signature key usage violations") Signed-off-by: Jiasheng Jiang ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 5 22:52:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 05 Aug 2025 20:52:37 +0000 Subject: [gnutls-devel] GnuTLS | ext/record_size_limit: add function to get record_size_limit (!1989) In-Reply-To: References: Message-ID: Wilfred Mallawa commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2670919720 Thank you @dueno! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1989#note_2670919720 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 08:03:41 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 06:03:41 +0000 Subject: [gnutls-devel] GnuTLS | tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak (!2007) In-Reply-To: References: Message-ID: Merge request !2007 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007 Project:Branches: purdue-university1/gnutls:patch29 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 08:03:47 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 06:03:47 +0000 Subject: [gnutls-devel] GnuTLS | tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak (!2007) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007#note_2671470143 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007#note_2671470143 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 08:10:59 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 06:10:59 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 was reviewed by Daiki Ueno -- Daiki Ueno started a new discussion on tests/crl_apis.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2671478075 > > char *crt_buf = gnutls_calloc(DN_MAX_LEN, sizeof(char)); > + if (crt_buf == NULL) Let's just abort with `assert(crt_buf != NULL);`. -- Daiki Ueno started a new discussion on tests/crl_apis.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2671478089 > + if (crl_buf == NULL) { > + gnutls_free(crt_buf); > + exit(1); Same here, if we exit upon failure in tests, we don't care about memory leak, so just abort without free. -- Daiki Ueno started a new discussion on tests/pskself2.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2671478096 > + gnutls_global_deinit(); > + fail("client: malloc failed\n"); > + return; Let's just abort on failure: `assert(user.data != NULL);`. -- Daiki Ueno started a new discussion on tests/rehandshake-switch-srp-id.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2671478102 > + if (generator->data == NULL) { > + fail("gnutls_malloc failed\n"); > + return GNUTLS_E_MEMORY_ERROR; Same here. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 08:12:17 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 06:12:17 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2671479889 If it is not too much burden, could you attach the actual modification to the test as a diff here? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2671479889 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 09:42:05 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 07:42:05 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: chenjianhu commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2671663997 Prior to this commit?after I modified?`nc1`?to?`nc2`?in `tests/name-constraints-merge.c:112`? ```diff diff --git a/tests/name-constraints-merge.c b/tests/name-constraints-merge.c index 03b3243cc..c8e99c63a 100644 --- a/tests/name-constraints-merge.c +++ b/tests/name-constraints-merge.c @@ -109,7 +109,7 @@ void doit(void) set_name("ccc.com", &name); ret = gnutls_x509_name_constraints_add_permitted( - nc1, GNUTLS_SAN_RFC822NAME, &name); + nc2, GNUTLS_SAN_RFC822NAME, &name); check_for_error(ret); ``` I got the error: ```powershell [root at localhost gnutls-3.8.2]# ./tests/name-constraints-merge check_test_result:59: Checking "xxx.ccc.com" should have failed (suite 0). ``` After applying this commit ```diff diff --git a/lib/x509/name_constraints.c b/lib/x509/name_constraints.c index 3c6e30630..2be6a2aaa 100644 --- a/lib/x509/name_constraints.c +++ b/lib/x509/name_constraints.c @@ -414,7 +414,10 @@ static int name_constraints_node_list_intersect( gnutls_assert(); goto cleanup; } - used = 1; + + if (t->type == t2->type) + used = 1; + // if intersection is not empty if (tmp != NULL) { // intersection for this type is not empty ``` the test case 'name-constraints-merge' can pass. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2671663997 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 12:40:09 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 10:40:09 +0000 Subject: [gnutls-devel] GnuTLS | GnuTLS doesn't support deriving the public key from the private one in ML-DSA (#1723) In-Reply-To: References: Message-ID: S,K,L WAP commented: https://gitlab.com/gnutls/gnutls/-/issues/1723#note_2672093514 https://www.facebook.com/profile.php?id=100041197530500 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1723#note_2672093514 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 6 12:41:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 06 Aug 2025 10:41:56 +0000 Subject: [gnutls-devel] GnuTLS | GnuTLS doesn't support deriving the public key from the private one in ML-DSA (#1723) In-Reply-To: References: Message-ID: S,K,L WAP commented on a discussion: https://gitlab.com/gnutls/gnutls/-/issues/1723#note_2672096530 https://gitlab.com/gnutls/gnutls/-/issues/1723#note_2672093514 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1723#note_2672096530 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 7 20:39:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Aug 2025 18:39:37 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: All discussions on merge request !2006 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 7 20:39:59 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Aug 2025 18:39:59 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Jiasheng Jiang commented on a discussion on tests/rehandshake-switch-srp-id.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2676183758 > printf("srp: username %s\n", username); > > generator->data = gnutls_malloc(1); > + if (generator->data == NULL) { > + fail("gnutls_malloc failed\n"); > + return GNUTLS_E_MEMORY_ERROR; I have fixed all the above issues. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2676183758 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 7 20:40:05 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 07 Aug 2025 18:40:05 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: All discussions on merge request !2006 were resolved by Jiasheng Jiang https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 8 03:48:52 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 08 Aug 2025 01:48:52 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: All discussions on merge request !1997 were resolved by chenjianhu https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 9 02:09:05 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 09 Aug 2025 00:09:05 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Merge request !2006 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 Project:Branches: purdue-university1/gnutls:patch28 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Aug 9 02:09:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 09 Aug 2025 00:09:12 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2678961569 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2678961569 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 12 09:21:43 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Aug 2025 07:21:43 +0000 Subject: [gnutls-devel] GnuTLS | Null binder algorithm type causing segmentation fault (#1729) References: Message-ID: Wilfred Mallawa created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1729 ## Description of problem: When `gnutls_psk_allocate_server_credentials2()` is invoked with GNUTLS_MAC_UNKNOWN. `_gnutls_mac_to_entry()` will return NULL as GNUTLS_MAC_UNKNOWN is not a `id` type in `hash_algorithms` list in `lib/algorithms/mac.c`. Later in `server_recv_params()`, `pskcred->binder_algo` is de-referenced without a NULL check. A simple change like diff below, fixes the segmentation fault. However, I am seeing errors from the target dmesg stating. "[ 1551.681456] nvmet_tcp: queue 1: short read, 8 bytes missing" Which I _think_ is a result of SHA384 being used instead of SHA256. ``` diff --git a/lib/algorithms/mac.c b/lib/algorithms/mac.c index e6a8835a3..f6307fc4c 100644 --- a/lib/algorithms/mac.c +++ b/lib/algorithms/mac.c @@ -204,6 +204,7 @@ static SYSTEM_CONFIG_OR_CONST mac_entry_st hash_algorithms[] = { .key_size = 32, .block_size = 16 }, { .name = "PBMAC1", .id = GNUTLS_MAC_PBMAC1, .placeholder = 1 }, + { .name = "MAC-UNKNOWN", .id = GNUTLS_MAC_UNKNOWN }, { .name = "MAC-NULL", .id = GNUTLS_MAC_NULL }, { 0, 0, 0, 0, 0, 0, 0, 0, 0 } ``` Should `gnutls_psk_allocate_server_credentials2()` be able to accept an `GNUTLS_MAC_UNKNOWN` type? What is the best solution? ## Version of gnutls used: Latest master. ## Distributor of gnutls (e.g., Ubuntu, Fedora, RHEL) N/A ## How reproducible: Connecting from a Linux host to a Linux target using NVMe-TCP/TLS. The segfault occurs during the handshake. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1729 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 12 14:55:49 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Aug 2025 12:55:49 +0000 Subject: [gnutls-devel] GnuTLS | Documentation and/or behaviour around empty passwords is confusing (#1730) References: Message-ID: Alicja Kario (@mention me if you need reply) created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1730 (using gnutls-3.8.10) If I perform export to PKCS#12 with `--password ''` then the resulting file is unreadable by NSS and OpenSSL. It's necessary to use the `--empty-password` switch to do that. Frankly, I would say that: 1. that is surprising behaviour (doesn't match what NSS or OpenSSL do) 2. it not at all clear from the man page that it is necessary for interoperability. The man page states ``` --password=str Password to use. You can use this option to specify the password in the command line in? stead of reading it from the tty. Note, that the command line arguments are available for view in others in the system. Specifying password as '' is the same as specifying no password. --null-password Enforce a NULL password. This option enforces a NULL password. This is different than the empty or no password in schemas like PKCS #8. --empty-password Enforce an empty password. This option enforces an empty password. This is different than the NULL or no password in schemas like PKCS #8. ``` Which suggests that there are three ways of encoding no password: the "no password", "empty password", and "NULL password". In reality there are only two: either the PBKDF gets a string of length zero, or a two byte string that encode the NULL character using UCS-2 (which is more standard behaviour). While I won't insist on changing the behaviour of `--password ''`, I think we can make the man page more descriptive about what is happening and what option is necessary for interoperability. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1730 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Aug 12 14:56:23 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 12 Aug 2025 12:56:23 +0000 Subject: [gnutls-devel] GnuTLS | Documentation and/or behaviour around empty passwords is confusing (#1730) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/issues/1730#note_2682973890 Downstream issue: https://issues.redhat.com/browse/RHEL-108678 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1730#note_2682973890 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Aug 13 03:06:09 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 13 Aug 2025 01:06:09 +0000 Subject: [gnutls-devel] GnuTLS | Null binder algorithm type causing segmentation fault (#1729) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1729#note_2684492595 Thank you for spotting this, @twilfredo. I would change `server_recv_params` to treat `pskcred->binder_algo == NULL` for auto-detection, rather than introducing a new MAC entry for UNKNOWN. Something like the following might work, though we probably need a unit test for that: ```diff diff --git a/lib/ext/pre_shared_key.c b/lib/ext/pre_shared_key.c index d709efa74b..0f40d81de8 100644 --- a/lib/ext/pre_shared_key.c +++ b/lib/ext/pre_shared_key.c @@ -886,9 +886,9 @@ retry_binder: gnutls_psk_key_flags flags; uint8_t ipsk[MAX_HASH_SIZE]; - prf = pskcred->binder_algo; - if (prf->id == GNUTLS_MAC_UNKNOWN) - prf = _gnutls_mac_to_entry(mac); + prf = pskcred->binder_algo == NULL ? + _gnutls_mac_to_entry(mac) : + pskcred->binder_algo; /* this fails only on configuration errors; as such we always * return its error code in that case */ @@ -983,7 +983,7 @@ retry_binder: * even for SHA384 PSKs, so we need to retry with SHA256 * to calculate the correct binder value for those. */ - if (prf->id == GNUTLS_MAC_UNKNOWN && mac == GNUTLS_MAC_SHA384) { + if (pskcred->binder_algo == NULL && mac == GNUTLS_MAC_SHA384) { mac = GNUTLS_MAC_SHA256; goto retry_binder; } ``` cc @hare1712 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1729#note_2684492595 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 14 06:23:42 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 14 Aug 2025 04:23:42 +0000 Subject: [gnutls-devel] GnuTLS | Trying to access a certain subdomain results in a stack overflow. (#1726) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1726#note_2686948654 Thank you for the report, @Qriist. I'm afraid I don't have access to a native Windows environment and the stack trace doesn't look very useful as these gnutls and nettle symbols are orthogonal; perhaps they are mixed up because of multi-threading? Reading the curl issue: it seems to be settled as an issue in the fork of GnuTLS in vcpkg. I'm closing this for now; if you can reproduce it with a package built from the canonical source, feel free to reopen. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1726#note_2686948654 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 14 06:23:41 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 14 Aug 2025 04:23:41 +0000 Subject: [gnutls-devel] GnuTLS | Trying to access a certain subdomain results in a stack overflow. (#1726) In-Reply-To: References: Message-ID: Issue was closed by Daiki Ueno Issue #1726: https://gitlab.com/gnutls/gnutls/-/issues/1726 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1726 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Aug 14 09:39:37 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 14 Aug 2025 07:39:37 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: chenjianhu commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2687188259 @dueno Hi,\ I?m a developer from China. Currently, GitLab is not providing services to the China region, so I?m unable to complete the pipeline process. Could I send you the modified patch and ask for your help to submit it? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2687188259 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:36:42 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:36:42 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2689199008 Sure, we would anyway need to do that as the CI is currently [restricted](https://blogs.gnome.org/dueno/optimizing-ci-resource-usage-in-upstream-projects/) to developers only. Before doing that we need to extend the test to avoid future regressions; I can do that with the information you provided. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2689199008 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:47:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:47:11 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2008) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008 Project:Branches: dueno/gnutls:wip/purdue-university1/malloc-check2 to gnutls/gnutls:master Author: Daiki Ueno This is a clone of !2006 and !2007 opened for CI purposes, including the following fixes: * tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak Add gnutls_free() to free p if error occurs to avoid memory leak. Fixes: b167cc373 ("tests: added checks on signature key usage violations") * Add check for memory allocation APIs to avoid NULL pointer dereference Add check for the return value of memory allocation APIs to avoid NULL pointer dereference. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:47:52 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:47:52 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2689205465 Cloned as !2008 for CI. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006#note_2689205465 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:47:52 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:47:52 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2006) In-Reply-To: References: Message-ID: Merge request !2006 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 Project:Branches: purdue-university1/gnutls:patch28 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2006 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:48:17 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:48:17 +0000 Subject: [gnutls-devel] GnuTLS | tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak (!2007) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007#note_2689205873 Cloned as !2008 for CI. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007#note_2689205873 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:48:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:48:18 +0000 Subject: [gnutls-devel] GnuTLS | tests/key-usage-ecdhe-rsa.c: Add gnutls_free() to avoid memory leak (!2007) In-Reply-To: References: Message-ID: Merge request !2007 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007 Project:Branches: purdue-university1/gnutls:patch29 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2007 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 02:48:52 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 00:48:52 +0000 Subject: [gnutls-devel] GnuTLS | tests/tls13-early-data-neg2: avoid a small memory leak (!1969) In-Reply-To: References: Message-ID: Merge request !1969 was unapproved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1969 Project:Branches: asosedkin/gnutls:tls13-early-data-neg2-fixes to gnutls/gnutls:master Author: Alexander Sosedkin Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 03:26:52 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 01:26:52 +0000 Subject: [gnutls-devel] GnuTLS | X509:Fix incorrect handling in name constraints merging (!1997) In-Reply-To: References: Message-ID: chenjianhu commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2689233113 Thank you, this is my code submission patch? [74afdfccbb8652ba46ede3132634ae65cd338a72.patch](/uploads/998364b71b7ec9767f17651dcb3834b3/74afdfccbb8652ba46ede3132634ae65cd338a72.patch) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1997#note_2689233113 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 03:40:17 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 01:40:17 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2008) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008#note_2689239328 Merging without approval, as the original MRs have already been reviewed. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008#note_2689239328 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 04:24:40 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 02:24:40 +0000 Subject: [gnutls-devel] GnuTLS | tls13/key_update: Expose a manual KeyUpdate function (!1965) In-Reply-To: References: Message-ID: All discussions on merge request !1965 were resolved by Alistair Francis https://gitlab.com/gnutls/gnutls/-/merge_requests/1965 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1965 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Aug 15 04:57:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 15 Aug 2025 02:57:16 +0000 Subject: [gnutls-devel] GnuTLS | Add check for memory allocation APIs to avoid NULL pointer dereference (!2008) In-Reply-To: References: Message-ID: Merge request !2008 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008 Project:Branches: dueno/gnutls:wip/purdue-university1/malloc-check2 to gnutls/gnutls:master Author: Daiki Ueno -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2008 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: