[gnutls-devel] GnuTLS | pkcs8: remove HAVE_LIBOQS ifdefs (!1924)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Tue Jan 21 23:34:08 CET 2025




Daiki Ueno commented on a discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1924#note_2308717389

 >  	 */
 >  
 >  	gnutls_pk_params_init(&pkey->params);
 > +	pkey->params.algo = algo;

For some reason, the convention of these `_decode_pkcs8_*_key` functions are to pass a partially filled `pkey` (i.e., `pkey->params.algo` is set) and then fill the rest. I would rather change this to take an algorithm ID as an argument.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1924#note_2308717389
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250121/5f3f4021/attachment.html>


More information about the Gnutls-devel mailing list