[gnutls-devel] GnuTLS | lib/ext/srp.c: Add gnutls_free() to avoid memory leak (!1956)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Tue May 13 19:51:13 CEST 2025
Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1956
Project:Branches: JiashengJiang/gnutls:patch6 to gnutls/gnutls:master
Author: Jiasheng Jiang
<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->
* lib/ext/srp.c: Add gnutls_free() to avoid memory leak
Add gnutls_free() to free priv->username if the allocation of priv->password fails to avoid memory leak.
Moreover, replace "return" with "goto" to avoid memory leak.
Fixes: a1a154223 ("Fixes and memory leak elimination in SRP authentication.")
Signed-off-by: JiashengJiang <jiasheng at purdue.edu>
## Checklist
* [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
* [ ] Code modified for feature
* [ ] Test suite updated with functionality tests
* [ ] Test suite updated with negative tests
* [ ] Documentation updated / NEWS entry present (for non-trivial changes)
* [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
## Reviewer's checklist:
* [ ] Any issues marked for closing are addressed
* [ ] There is a test suite reasonably covering new functionality or modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
* [ ] This feature/change has adequate documentation added
* [ ] No obvious mistakes in the code
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1956
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250513/d01f33e1/attachment.html>
More information about the Gnutls-devel
mailing list