[gnutls-devel] GnuTLS | src/common.c: Move gnutls_free() out of out lable to avoid double free (!1966)

[Read-only notification of GnuTLS library development activities]

Jiasheng Jiang created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966

Project:Branches: JiashengJiang/gnutls:patch14 to gnutls/gnutls:master
Author:   Jiasheng Jiang




<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->

* src/common.c: Move gnutls_free() out of out lable to avoid double free

If gnutls_hex_encode2() fails, hex.data will be freed. As a result, goto out and double free hex.data will cause undefined behavior.

Fixes: 96a5dd4fa ("serv, cli: add --keymatexport option")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool at gmail.com>

## Checklist
 * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250529/f72b8398/attachment.html>