[gnutls-devel] GnuTLS | pkcs11: try to initialize modules in thread-safe mode (!2014)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2014 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on lib/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014#note_2743835820

 > +			free(name);
 > +			pkcs11_provider_deinit(&provider);
 > +			return ret;

Indeed, this should be a `continue` rather than `return`. I've changed it.

--
  
Daiki Ueno commented on a discussion on lib/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014#note_2743835824

 >  					  name);
 > +			free(name);
 >  			return GNUTLS_E_INT_RET_0;

The error code just signifies the module is reinitialized. While the first caller (`gnutls_pkcs11_add_provider`) turns it to 0 as the function returns the value, the second caller (`auto_load`) doesn't need to do that, as it discards `ret`.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250911/44d627de/attachment.html>