<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div>
<p dir="auto"><a href="https://gitlab.com/simo5" data-user="2918402" data-reference-type="user" data-container="body" data-placement="bottom" class="gfm gfm-project_member has-tooltip" title="Simo Sorce">@simo5</a></p>
<ol start="0" dir="auto">
<li>
<p>Why are you adding all these algorithms to GnuTLS? (You have added CFB8, now comes CMAC and I saw that you were working on XTS.) Do you have any application in mind, which would benefit from using GnuTLS, rather than using Nettle directly?</p>
</li>
<li>
<p>Could you please change just <code>CMAC_128</code>/<code>CMAC_256</code> to <code>AES_CMAC_128</code>/<code>AES_CMAC_256</code> (and so on for lower case names). Nettle code uses cmac128 for generic 128-bit-block CMAC version (e.g. for GOST ciphers I'm adding <code>cmac64_*</code> interface). However CMAC code is not specific to AES (NIST defines TDEA-CMAC-xxx, CMAC computed using 3DES as basis).</p>
</li>
<li>
<p><a href="https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38b.pdf" rel="nofollow noreferrer noopener" target="_blank">NIST SP800-38B</a> contained test vectors with tags which are exactly 16 bytes long. It is replaced now, but <a href="https://csrc.nist.gov/CSRC/media/Projects/Cryptographic-Standards-and-Guidelines/documents/examples/AES_CMAC.pdf" rel="nofollow noreferrer noopener" target="_blank">examples for AES-CMAC</a> page also has 16-byte tags. Could you please re-verify them and just attribute them to NIST SP800-38A?</p>
</li>
<li>
<p>I think it's find to always return 16 bytes. If anybody wants, he can handle tag truncation manually.</p>
</li>
<li>
<p>Which part of GnuTLS MAC interface seems misnamed to you?</p>
</li>
</ol>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/786#note_112236320">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/6e417899b33651aaf236dc63c8c4bd72/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/786#note_112236320"}}</script>
</p>
</div>
</body>
</html>