<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div></div>
<p dir="auto">Can we have a simple <code>return</code> (do nothing) instead of <code>abort()</code> in gnutls_transport_set_fastopen() ?</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext"> if (connect_addrlen > (socklen_t)sizeof(session->internals.tfo.connect_addr)) {</span>
<span id="LC2" class="line" lang="plaintext"> gnutls_assert();</span>
<span id="LC3" class="line" lang="plaintext"> abort();</span>
<span id="LC4" class="line" lang="plaintext"> }</span></code></pre>
<p dir="auto">Because in production library code I wouldn't expect an abort(). Better having an error returned or a no-op.</p>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/603">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/0a9ddf953db9880eaa1d094b9b920950/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/603"}}</script>
</p>
</div>
</body>
</html>