<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=utf-8" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<div style="">

<blockquote dir="auto">

<p>AFAIU, ucs2 is a fixed length coding, while utf16 is a variable length one, so for a specific subset it might work, but in general, it won't.</p>

</blockquote>

<p dir="auto">I understand that, but if you see the function I referenced, it does utf8->utf16 conversion. The UCS2 is only on its name. Maybe we should rename it as part of this changeset to avoid future confusion.</p>

<blockquote dir="auto">

<p>But in any case, theory aside, the tests were failing with the ucs2 variant, and passing with the utf16 one</p>

</blockquote>

<p dir="auto">What does it fail? There could be a bug here. Does windows require some specific canonical form? In the past we were using the windows conversion functions as you introduced them here, however we removed them because they had no reference to what standard they were using, my assumption was UCS2 because they didn't easily support variable length encoding, and thus the current name of the function.</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/835#note_125295115">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/b1b32a6e3e918322ecb3a1fbcc1fcf10/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/835#note_125295115"}}</script>

</p>

</div>

</body>

</html>