<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a>
commented on a discussion
on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/819#note_125353052">tests/cert-tests/certtool</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="43" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
43
</td>
<td class="diff-line-num new_line" data-linenumber="44" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
44
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC44" class="line" lang="shell"> <span class="nb" style="color: #0086b3;">exit </span>1</span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="44" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
44
</td>
<td class="diff-line-num new_line" data-linenumber="45" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
45
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC45" class="line" lang="shell"> <span class="k" style="font-weight: 600;">fi</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="45" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
45
</td>
<td class="diff-line-num new_line" data-linenumber="46" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
46
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC46" class="line" lang="shell"></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="46" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
46
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC46" class="line" lang="shell"> <span class="c" style="color: #998; font-style: italic;">#check whether <span class="idiff left right">ask-pass</span> is being honoured</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
47
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC47" class="line" lang="shell"> <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">SETSID</span><span class="k" style="font-weight: 600;">}</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">CERTTOOL</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">--generate-self-signed</span> <span class="nt" style="color: navy;">--load-privkey</span> <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">TMPFILE1</span><span class="k" style="font-weight: 600;">}</span> <span class="nt" style="color: navy;">--template</span> <span class="s2" style="color: #d14;"><span class="idiff left">"</span></span><span class="k" style="font-weight: 600;"><span class="idiff">${</span></span><span class="nv" style="color: teal;"><span class="idiff">srcdir</span></span><span class="k" style="font-weight: 600;"><span class="idiff">}</span></span><span class="s2" style="color: #d14;"><span class="idiff">/templates/template-test.tmpl"</span></span><span class="idiff"> </span><span class="nt" style="color: navy;"><span class="idiff">--ask-pass</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">></span></span><span class="k" style="font-weight: 600;"><span class="idiff">${</span></span><span class="nv" style="color: teal;"><span class="idiff">TMPFILE2</span></span><span class="k" style="font-weight: 600;"><span class="idiff">}</span></span><span class="idiff"> 2>&1 </span><span class="o" style="font-weight: 600;"><span class="idiff"><<<</span></span><span class="k" style="font-weight: 600;"><span class="idiff">${</span></span><span class="nv" style="color: teal;"><span class="idiff">PASS</span></span><span class="k" style="font-weight: 600;"><span class="idiff right">}</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="48" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
48
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC48" class="line" lang="shell"><span class="idiff left"> </span><span class="k" style="font-weight: 600;"><span class="idiff">if </span></span><span class="nb" style="color: #0086b3;"><span class="idiff">test</span></span><span class="idiff"> </span><span class="nv" style="color: teal;"><span class="idiff">$?</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">!=</span></span><span class="idiff"> 0</span><span class="p"><span class="idiff">;</span></span><span class="k" style="font-weight: 600;"><span class="idiff right">then</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="49" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
49
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC49" class="line" lang="shell"><span class="k" style="font-weight: 600;"><span class="idiff left"> </span></span><span class="nb" style="color: #0086b3;"><span class="idiff">cat</span></span><span class="idiff"> </span><span class="k" style="font-weight: 600;"><span class="idiff">${</span></span><span class="nv" style="color: teal;"><span class="idiff">TMPFILE2</span></span><span class="k" style="font-weight: 600;"><span class="idiff right">}</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="50" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
50
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC50" class="line" lang="shell"> <span class="idiff left"> </span><span class="nb" style="color: #0086b3;"><span class="idiff">echo</span></span><span class="idiff"> </span><span class="s2" style="color: #d14;"><span class="idiff right">"cert generation failed"</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="51" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
51
</td>
<td class="diff-line-num new_line old" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC51" class="line" lang="shell"> <span class="nb" style="color: #0086b3;"><span class="idiff left">exit </span></span><span class="idiff right">1</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="52" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="47" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
47
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC47" class="line" lang="shell"> <span class="c" style="color: #998; font-style: italic;">#check whether <span class="idiff left right">password</span> is being honoured</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="52" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="48" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
48
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC48" class="line" lang="shell"> <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">SETSID</span><span class="k" style="font-weight: 600;">}</span> <span class="s2" style="color: #d14;">"</span><span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">CERTTOOL</span><span class="k" style="font-weight: 600;">}</span><span class="s2" style="color: #d14;">"</span> <span class="nt" style="color: navy;">--generate-self-signed</span> <span class="nt" style="color: navy;">--load-privkey</span> <span class="k" style="font-weight: 600;">${</span><span class="nv" style="color: teal;">TMPFILE1</span><span class="k" style="font-weight: 600;">}</span> <span class="nt" style="color: navy;">--template</span> <span class="k" style="font-weight: 600;"><span class="idiff left">${</span></span><span class="nv" style="color: teal;"><span class="idiff">srcdir</span></span><span class="k" style="font-weight: 600;"><span class="idiff">}</span></span><span class="idiff">/templates/template-test.tmpl </span><span class="nt" style="color: navy;"><span class="idiff">--ask-pass</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">></span></span><span class="k" style="font-weight: 600;"><span class="idiff">${</span></span><span class="nv" style="color: teal;"><span class="idiff">TMPFILE2</span></span><span class="k" style="font-weight: 600;"><span class="idiff">}</span></span><span class="idiff"> 2>&1 </span><span class="o" style="font-weight: 600;"><span class="idiff"><<</span></span><span class="no" style="color: teal;"><span class="idiff right">EOF</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="52" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="49" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
49
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC49" class="line" lang="shell"><span class="nv" style="color: teal;"><span class="idiff left right">$PASS</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="52" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="50" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
50
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC50" class="line" lang="shell"><span class="no" style="color: teal;"><span class="idiff left right">EOF</span></span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="52" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="51" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
51
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC51" class="line" lang="shell"> <span class="k" style="font-weight: 600;"><span class="idiff left">if </span></span><span class="nb" style="color: #0086b3;"><span class="idiff">test</span></span><span class="idiff"> </span><span class="nv" style="color: teal;"><span class="idiff">$?</span></span><span class="idiff"> </span><span class="o" style="font-weight: 600;"><span class="idiff">!=</span></span><span class="idiff"> 0</span><span class="p"><span class="idiff">;</span></span><span class="idiff"> </span><span class="k" style="font-weight: 600;"><span class="idiff right">then</span></span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">Another solution would be to check for the current shell in runtime. If the script is not run by bash or dash, we return 77 (SKIP). Maybe we can even check if <code><<EOF</code> works or not. I have to check this out.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/819#note_125353052">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/c933879a086690e19a893c351f882310/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/819#note_125353052"}}</script>
</p>
</div>
</body>
</html>