<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">Update - LibreSSL portable dev already sent patch to OpenBSD list that fixes the AES CCM tests. The ChaCha20-poly1305 will take more work on their part.</p>
<p dir="auto">So with the patch their dev sent to their mailing list applied, the following modification (the second part of patch) to the PR works:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">diff -ur gnutls-3.6.5.orig/tests/slow/cipher-openssl-compat.c gnutls-3.6.5/tests/slow/cipher-openssl-compat.c</span>
<span id="LC2" class="line" lang="plaintext">--- gnutls-3.6.5.orig/tests/slow/cipher-openssl-compat.c 2018-03-22 00:56:48.000000000 -0700</span>
<span id="LC3" class="line" lang="plaintext">+++ gnutls-3.6.5/tests/slow/cipher-openssl-compat.c 2018-12-26 05:26:10.916608565 -0800</span>
<span id="LC4" class="line" lang="plaintext">@@ -98,7 +98,6 @@</span>
<span id="LC5" class="line" lang="plaintext"> #if OPENSSL_VERSION_NUMBER >= 0x10100000L</span>
<span id="LC6" class="line" lang="plaintext"> if (gcipher == GNUTLS_CIPHER_AES_128_CCM</span>
<span id="LC7" class="line" lang="plaintext"> || gcipher == GNUTLS_CIPHER_AES_256_CCM) {</span>
<span id="LC8" class="line" lang="plaintext">- assert(EVP_CIPHER_CTX_init(ctx)==1);</span>
<span id="LC9" class="line" lang="plaintext"> assert(EVP_CipherInit_ex(ctx, evp_cipher, 0, 0, 0, 0) ></span>
<span id="LC10" class="line" lang="plaintext"> 0);</span>
<span id="LC11" class="line" lang="plaintext"> </span>
<span id="LC12" class="line" lang="plaintext">@@ -190,9 +189,11 @@</span>
<span id="LC13" class="line" lang="plaintext"> cipher_test("aes-128-gcm", GNUTLS_CIPHER_AES_128_GCM, 16);</span>
<span id="LC14" class="line" lang="plaintext"> cipher_test("aes-256-gcm", GNUTLS_CIPHER_AES_256_GCM, 16);</span>
<span id="LC15" class="line" lang="plaintext"> #if OPENSSL_VERSION_NUMBER >= 0x10100000L</span>
<span id="LC16" class="line" lang="plaintext">+# if !defined (LIBRESSL_VERSION_NUMBER)</span>
<span id="LC17" class="line" lang="plaintext"> if (!gnutls_fips140_mode_enabled()) {</span>
<span id="LC18" class="line" lang="plaintext"> cipher_test("chacha20-poly1305", GNUTLS_CIPHER_CHACHA20_POLY1305, 16);</span>
<span id="LC19" class="line" lang="plaintext"> }</span>
<span id="LC20" class="line" lang="plaintext">+# endif</span>
<span id="LC21" class="line" lang="plaintext"> cipher_test("aes-128-ccm", GNUTLS_CIPHER_AES_128_CCM, 16);</span>
<span id="LC22" class="line" lang="plaintext"> cipher_test("aes-256-ccm", GNUTLS_CIPHER_AES_256_CCM, 16);</span>
<span id="LC23" class="line" lang="plaintext"> #endif</span></code></pre>
<p dir="auto">My guess is the fix for AES CCM will be in next LibreSSL but I don't know when it will be released.
I'm going to retract <a href="https://gitlab.com/gnutls/gnutls/merge_requests/845" data-original="!845" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="21341046" data-reference-type="merge_request" data-container="body" data-placement="bottom" title="Update cipher-openssl-compat.c for LibreSSL abuse of OPENSSL_VERSION_NUMBER" class="gfm gfm-merge_request has-tooltip">!845</a> because this PR fixes the fixable issue the right way.</p>
<p dir="auto">Whether you want to add LibreSSL specific fix to second issue or just wait for the chacha20-poly1305 to be added to their EVP (it sounds like it will) and deal w/ occasional people reporting test failures with LibreSSL I don't have an opinion on what is best, either is fine by me.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/846#note_127317115">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/f49c14115cefc7e10ec8a1d3006d41c1/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/846#note_127317115"}}</script>
</p>
</div>
</body>
</html>