<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a>
commented on a discussion
on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/889#note_134251478">lib/priority.c</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="1412" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1412
</td>
<td class="diff-line-num new_line" data-linenumber="1408" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1408
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1408" class="line" lang="c"><span class="cm" style="color: #998; font-style: italic;"> * a pre-TLS1.2 protocol is there; that is because servers which</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="1413" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1413
</td>
<td class="diff-line-num new_line" data-linenumber="1409" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1409
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1409" class="line" lang="c"><span class="cm" style="color: #998; font-style: italic;"> * do not support TLS1.3 will negotiate TLS1.2 if seen a TLS1.3 handshake */</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="1414" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1414
</td>
<td class="diff-line-num new_line" data-linenumber="1410" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1410
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1410" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333;">unlikely</span><span class="p">((</span><span class="o" style="font-weight: 600;">!</span><span class="n" style="color: #333;">have_psk</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">tlsmax</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">tlsmax</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">id</span> <span class="o" style="font-weight: 600;">>=</span> <span class="n" style="color: #333;">GNUTLS_TLS1_3</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">priority_cache</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">groups</span><span class="p">.</span><span class="n" style="color: #333;">size</span> <span class="o" style="font-weight: 600;">==</span> <span class="mi" style="color: #099;">0</span><span class="p">))</span> <span class="o" style="font-weight: 600;">||</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="1415" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
1415
</td>
<td class="diff-line-num new_line old" data-linenumber="1411" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC1415" class="line" lang="c"> <span class="p">(</span><span class="o" style="font-weight: 600;">!</span><span class="n" style="color: #333;">have_tls12</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">have_pre_tls12</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">have_tls13</span><span class="p">))</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="">
<td class="diff-line-num old old_line" data-linenumber="1416" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
1416
</td>
<td class="diff-line-num new_line old" data-linenumber="1411" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content noteable_line old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC1416" class="line" lang="c"> <span class="k" style="font-weight: 600;">for</span> <span class="p">(</span><span class="n" style="color: #333;">i</span> <span class="o" style="font-weight: 600;">=</span> <span class="mi" style="color: #099;">0</span><span class="p">;</span> <span class="n" style="color: #333;">i</span> <span class="o" style="font-weight: 600;"><</span> <span class="n" style="color: #333;">priority_cache</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">protocol</span><span class="p">.</span><span class="n" style="color: #333;">num_priorities</span><span class="p">;</span> <span class="n" style="color: #333;">i</span><span class="o" style="font-weight: 600;">++</span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="1417" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1411" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1411
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1411" class="line" lang="c"> <span class="p">(</span><span class="o" style="font-weight: 600;">!</span><span class="n" style="color: #333;">have_tls12</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">have_pre_tls12</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">have_tls13</span><span class="p">))</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="1417" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1412" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1412
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1412" class="line" lang="c"> <span class="p">{</span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">Having the brace at the end of a continuation line is harder to read when you quickly read source code. This is just my personal observation/experience after so many years of reading code. Rules are for breaking them ;-)</p>
<p dir="auto">But in this case I don't mind (it isn't my project). I'll amend it.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/889#note_134251478">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/3ade90642146be2f94cb8001c5ec78b4/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/889#note_134251478"}}</script>
</p>
</div>
</body>
</html>