<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">Looking at priority.c:1266. The macro REMOVE_TLS13_IN_LOOP seems wrong or at least the following code.</p>
<p dir="auto">REMOVE_TLS13_IN_LOOP always 'continues' (jumps to the main loop) when <code>vers->tls13_sem</code> is set. That means that the following code</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext"> if (vers->tls13_sem)</span>
<span id="LC2" class="line" lang="plaintext"> have_tls13 = 1;</span></code></pre>
<p dir="auto">is never executed and thus <code>have_tls13</code> stays always 0. But <code>have_tls13</code> is also checked later...</p>
<p dir="auto">Please review !</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/679#note_134092641">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/9bd8f4afec48835671ad216f5adaf8a8/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/679#note_134092641"}}</script>
</p>
</div>
</body>
</html>