<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">The main issue is that <code>our m4/ax_code_coverage.m4</code> gets overwritten during <code>./bootstrap</code>:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">aclocal: overwriting 'm4/ax_code_coverage.m4' with '/usr/share/aclocal/ax_code_coverage.m4'</span></code></pre>
<p dir="auto">In our CI images there is no <code>autoconf-archive</code>, so the file doesn't get overwritten. And even if we install <code>autoconf-archive</code>, <code>ax_code_coverage.m4</code> is compatible or identical (version 25) in Fedora and Debian images.</p>
<p dir="auto">The new 2019 version 33 of <code>ax_code_coverage.m4</code> needs other macros from <code>autoconf-archive</code>. So if we that file in our repo, we also need a 2019 version of <code>autoconf-archive</code> due to the above mentioned overwriting.</p>
<p dir="auto">I currently don't know how to prevent the overwriting. If we can solve that, we could possibly have code like this in configure.ac:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">m4_ifdef([CODE_COVERAGE_RULES], [], [</span>
<span id="LC2" class="line" lang="plaintext"> CODE_COVERAGE_RULES = "include $(top_srcdir)/aminclude_static.am"</span>
<span id="LC3" class="line" lang="plaintext"> AC_SUBST([CODE_COVERAGE_RULES])</span>
<span id="LC4" class="line" lang="plaintext">])</span></code></pre>
<p dir="auto">and leave <code>Makefile.am</code> as is.</p>
<p dir="auto">Any idea ? What does your patch look like ?</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/905#note_138052341">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/5657a2cd7d44e22bd7b90d51601c355a/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/905#note_138052341"}}</script>
</p>
</div>
</body>
</html>