<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">I'm trying to think if we can do this at all without breaking ABI expectations. Previously a client would set the PSK credentials (e.g., a callback), with <code>gnutls_psk_set_client_credentials_function(psk_cred, psk_callback)</code> and will be called only if <code>PSK</code> is listed as priority string, and PSK is negotiated (under TLS1.2), or during client hello sending (under TLS1.3).</p>
<p dir="auto">If we enable the PSK ciphersuites explicitly we can have an application getting to the callback when previously it wouldn't get there if the <code>PSK</code> were not listed as priority strings. <code>gnutls-cli</code> itself works that way, and if we enable PSK unconditionally it asks for username when connecting to any site.</p>
<p dir="auto">Breaking <code>gnutls-cli</code> is not a big deal (we can fix it), but I worry if there are applications which rely on that behavior too (i.e., the PSK credentials are set but do not indicate the intention to use PSK). I'm open to suggestions here. An approach may be to mark the application as a PSK application via a <code>gnutls_init</code> flag, but that would be yet another way to specify PSK.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/issues/680#note_138319341">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/96ac35da85ba9854d2f18a1a21f0f83d/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://gitlab.com/gnutls/gnutls/issues/680#note_138319341"}}</script>
</p>
</div>
</body>
</html>