<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">Did you see that "gnutls_x509_crt_init: Fix dereference of NULL pointer" was a previously unrecognized NULL pointer dereference - but after setting the freed pointer to NULL, clang's scan-build detected it.</p>
<p dir="auto">But back to the topic, my premises were</p>
<ul dir="auto">
<li>just apply when building GnuTLS</li>
<li>make it transparent, so we devs don't have to carry another macro in mind</li>
<li>do not care what policies outside projects have that include <code>gnutls.h</code>
</li>
<li>(some more technical stuff, not relevant here)</li>
</ul>
<p dir="auto">So, the idea was to just use <code>gnutls_free</code> as we all are used to instead of adding a new macro. By doing so, we can't do anything wrong or forget a new macro when changing or writing new code. It appears easy and elegant. Even if someone adds an additional (and redundant) <code>p=NULL</code> after a <code>gnutls_free(p)</code>, compilers would optimize it out. Clang even tells you that a previously assigned value wasn't used.</p>
<p dir="auto">This is why I am against adding a new macro. And exporting such is not of great use to any project.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/923#note_140851875">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/39f2e7358b659e480fa59f9e116bd9b2/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/923#note_140851875"}}</script>
</p>
</div>
</body>
</html>