<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=utf-8" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<div style="">

<blockquote dir="auto">

<blockquote>

<p>We should also turn this off in the valgrind and address sanitizer CI runs, so that any memory errors are not masked by it.

But maybe you have something in mind that I don't think of !?</p>

</blockquote>

</blockquote>

<p dir="auto">I was thinking masking a double free such as:</p>

<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">gnutls_free(ptr);</span>

<span id="LC2" class="line" lang="plaintext">/* do something */</span>

<span id="LC3" class="line" lang="plaintext">gnutls_free(ptr);</span></code></pre>

<p dir="auto">But thinking it further, this is now a "logic" error with no repercussions whatsoever, and the fact that we eliminate explicit nullifications, makes such modification of the lib (without gnutls_free setting ptr to null) quite impossible to operate. So I no longer think this is a good idea.</p>

<blockquote dir="auto">

<p>Regarding <code>CONTRIBUTION.md</code> I'd suggest a new section/paragraph with a short introduction to the basic GnuTLS memory functions. Is that OK ?</p>

</blockquote>

<p dir="auto">It makes sense to me.</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/923#note_141609187">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/80776d972116f6452807723e622b3465/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/923#note_141609187"}}</script>

</p>

</div>

</body>

</html>