<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777777;">
Project:Branches: bmwiedemann/gnutls:date → gnutls/gnutls:master
</p>
<div>
<p dir="auto">Add a description of the new feature/bug fix. Reference any relevant bugs.</p>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
<p dir="auto">Without this patch, building gnutls in the year 2034 produced such a diff in various binaries:</p>
<pre class="code highlight js-syntax-highlight diff" lang="diff" v-pre="true"><code><span id="LC1" class="line" lang="diff">/usr/bin/certtool differs in ELF section .rodata</span>
<span id="LC2" class="line" lang="diff"><span class="gu">@@ -1150,7 +1150,7 @@</span></span>
<span id="LC3" class="line" lang="diff"> 2e790 00000000 00000000 00000000 00000000 ................</span>
<span id="LC4" class="line" lang="diff"> 2e7a0 63657274 746f6f6c 20332e36 2e360a43 certtool 3.6.6.C</span>
<span id="LC5" class="line" lang="diff"> 2e7b0 6f707972 69676874 20284329 20323030 opyright (C) 200</span>
<span id="LC6" class="line" lang="diff"><span class="gd">- 2e7c0 302d3230 31392046 72656520 536f6674 0-2019 Free Soft</span></span>
<span id="LC7" class="line" lang="diff"><span class="gi">+ 2e7c0 302d3230 33342046 72656520 536f6674 0-2034 Free Soft</span></span>
<span id="LC8" class="line" lang="diff"> 2e7d0 77617265 20466f75 6e646174 696f6e2c ware Foundation,</span>
<span id="LC9" class="line" lang="diff"> 2e7e0 20616e64 206f7468 6572732c 20616c6c and others, all</span>
<span id="LC10" class="line" lang="diff"> 2e7f0 20726967 68747320 72657365 72766564 rights reserved</span></code></pre>
<p dir="auto">See <a href="https://reproducible-builds.org/" rel="nofollow noreferrer noopener" target="_blank">https://reproducible-builds.org/</a> for why this matters.</p>
<p dir="auto">Also claiming Copyright for future years seems wrong.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/928">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/912c602c28a9fc22fda8303307ee8d19/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/928"}}</script>
</p>
</div>
</body>
</html>