<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777777;">
Project:Branches: chouquette/gnutls:use_topendir → gnutls/gnutls:master
</p>
<div>
<p dir="auto">This is reintroducing the changes from <a href="https://gitlab.com/gnutls/gnutls/merge_requests/835" data-original="!835" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="20295051" data-reference-type="merge_request" data-container="body" data-placement="bottom" title="Windows & Windows Store store patches" class="gfm gfm-merge_request has-tooltip">!835</a> (and thus reverting those introducing in <a href="https://gitlab.com/gnutls/gnutls/merge_requests/860" data-original="!860" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="21815714" data-reference-type="merge_request" data-container="body" data-placement="bottom" title='Revert "verify-high2: Fix cert dir iteration on Win32"' class="gfm gfm-merge_request has-tooltip">!860</a>)</p>
<p dir="auto">The failure was due to an incorrect byte order in the path provided to _topendir.
I'm not sure if the 3rd patch is correct, there might be a macro/constant that can be use to express that the <code>_gnutls_utf8_to_ucs2</code> caller wants native by order.
Patch 2 & 3 might be better of squashed, but for the sake of reviewing, I think they're better of split for now.</p>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/931">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/0a23372c9ba3d081eabe5f4cae895af2/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/931"}}</script>
</p>
</div>
</body>
</html>