<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">Thanks a lot for the quick fix!</p>
<p dir="auto">This seems to fix the observable issue from <a href="https://gitlab.com/gnutls/gnutls/issues/713" data-original="#713" data-link="false" data-link-reference="false" data-project="179611" data-issue="18483954" data-reference-type="issue" data-container="body" data-placement="bottom" title="False start and early start are not multi-thread recv/send safe" class="gfm gfm-issue has-tooltip">#713</a>, however the race is still present, as the accesses to <code>session->internals.recv_state</code> are not atomic</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">WARNING: ThreadSanitizer: data race (pid=19622)</span>
<span id="LC2" class="line" lang="plaintext"> Read of size 4 at 0x7b8c00012014 by thread T11:</span>
<span id="LC3" class="line" lang="plaintext"> #0 gnutls_record_send2 /home/chouquette/dev/vlc/contrib/native/gnutls/lib/record.c:1982 (libgnutls_plugin.so+0x20c52)</span>
<span id="LC4" class="line" lang="plaintext"> #1 gnutls_record_send /home/chouquette/dev/vlc/contrib/native/gnutls/lib/record.c:1943 (libgnutls_plugin.so+0x2111f)</span>
<span id="LC5" class="line" lang="plaintext"> #2 gnutls_Send ../../modules/misc/gnutls.c:175 (libgnutls_plugin.so+0x197f3)</span>
<span id="LC6" class="line" lang="plaintext"> #3 vlc_https_send ../../modules/access/http/h2output.c:204 (libhttps_plugin.so+0xfddd)</span>
<span id="LC7" class="line" lang="plaintext"> #4 vlc_h2_frame_send ../../modules/access/http/h2output.c:250 (libhttps_plugin.so+0xffdc)</span>
<span id="LC8" class="line" lang="plaintext"> #5 vlc_h2_output_thread ../../modules/access/http/h2output.c:265 (libhttps_plugin.so+0x1006d)</span>
<span id="LC9" class="line" lang="plaintext"> #6 vlc_h2_client_output_thread ../../modules/access/http/h2output.c:299 (libhttps_plugin.so+0x101fb)</span>
<span id="LC10" class="line" lang="plaintext"> #7 <null> <null> (libtsan.so.0+0x29b4d)</span>
<span id="LC11" class="line" lang="plaintext"></span>
<span id="LC12" class="line" lang="plaintext"> Previous write of size 4 at 0x7b8c00012014 by thread T12:</span>
<span id="LC13" class="line" lang="plaintext"> #0 check_session_status /home/chouquette/dev/vlc/contrib/native/gnutls/lib/record.c:1689 (libgnutls_plugin.so+0x20204)</span>
<span id="LC14" class="line" lang="plaintext"> #1 _gnutls_recv_int /home/chouquette/dev/vlc/contrib/native/gnutls/lib/record.c:1752 (libgnutls_plugin.so+0x2055c)</span>
<span id="LC15" class="line" lang="plaintext"> #2 gnutls_record_recv /home/chouquette/dev/vlc/contrib/native/gnutls/lib/record.c:2262 (libgnutls_plugin.so+0x215d4)</span>
<span id="LC16" class="line" lang="plaintext"> #3 gnutls_Recv ../../modules/misc/gnutls.c:146 (libgnutls_plugin.so+0x196d0)</span>
<span id="LC17" class="line" lang="plaintext"> #4 vlc_https_recv ../../modules/access/http/h2conn.c:563 (libhttps_plugin.so+0x122c4)</span>
<span id="LC18" class="line" lang="plaintext"> #5 vlc_h2_frame_recv ../../modules/access/http/h2conn.c:606 (libhttps_plugin.so+0x12453)</span>
<span id="LC19" class="line" lang="plaintext"> #6 vlc_h2_recv_thread ../../modules/access/http/h2conn.c:656 (libhttps_plugin.so+0x1270d)</span>
<span id="LC20" class="line" lang="plaintext"> #7 <null> <null> (libtsan.so.0+0x29b4d)</span></code></pre>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/935#note_144608641">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/8edb861a38c8ae014b6e279303f2cfca/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/935#note_144608641"}}</script>
</p>
</div>
</body>
</html>