<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777777;">
Project:Branches: dakotarwilliams/gnutls:libidn2-symbol-fix-el6 → gnutls/gnutls:gnutls_3_5_x
</p>
<div>
<p dir="auto">libidn2 >=2.1.0 removed <code>_idn2_punycode_[en|de]code</code> symbols from its
library. The preprocessor check in <code>str-idna.c</code> only checks for the
existence of libidn2, not the version. Therefore the symbol is declared,
but missing a definition. This showed up after linking to GnuTLS on EL6, which recently updated their distributed version of libidn2 to 2.1.1a.
A simplified version of this patch has already been accepted into the <a href="https://src.fedoraproject.org/rpms/gnutls30/pull-request/1" rel="nofollow noreferrer noopener" target="_blank">EL6 package</a>.</p>
<p dir="auto">Also as part of this merge request, I cherry-picked the copyright update so that the static-analysis test would pass.</p>
<p dir="auto">The Debian test seems to be failing due to OpenSSL being upgraded to 1.1.1a and exhibits the same behavior as <a href="https://gitlab.com/gnutls/gnutls/issues/572" data-original="https://gitlab.com/gnutls/gnutls/issues/572" data-link="false" data-link-reference="true" data-project="179611" data-issue="14397439" data-reference-type="issue" data-container="body" data-placement="bottom" title="testcompat-main-openssl fails - 140270991812416:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small:../ssl/ssl_rsa.c:310:" class="gfm gfm-issue has-tooltip">#572</a>. I could use some guidance on how it was fixed for 3.6 so that it could be brought in here. I tried an approach of picking a few relevant-looking commits (<a href="https://gitlab.com/gnutls/gnutls/commit/c5a251d31cd987edd02cce142dac9665f5034d3b" data-original="c5a251d31cd987edd02cce142dac9665f5034d3b" data-link="false" data-link-reference="false" data-project="179611" data-commit="c5a251d31cd987edd02cce142dac9665f5034d3b" data-reference-type="commit" data-container="body" data-placement="bottom" title="tests: added interop tests with openssl under TLS1.3" class="gfm gfm-commit has-tooltip">c5a251d3</a>, <a href="https://gitlab.com/gnutls/gnutls/commit/d4202bc951de81ea4799ff74b37527f3f6ac1249" data-original="d4202bc951de81ea4799ff74b37527f3f6ac1249" data-link="false" data-link-reference="false" data-project="179611" data-commit="d4202bc951de81ea4799ff74b37527f3f6ac1249" data-reference-type="commit" data-container="body" data-placement="bottom" title="tests: testcompat-openssl: disable DSS ciphersuites under SSL3.0" class="gfm gfm-commit has-tooltip">d4202bc9</a>, and <a href="https://gitlab.com/gnutls/gnutls/commit/b9709cac12a0f98442042d20c02a5d1e3c8efe5a" data-original="b9709cac12a0f98442042d20c02a5d1e3c8efe5a" data-link="false" data-link-reference="false" data-project="179611" data-commit="b9709cac12a0f98442042d20c02a5d1e3c8efe5a" data-reference-type="commit" data-container="body" data-placement="bottom" title="testcompat-openssl: do not test DSS or small curves with 1.1.1" class="gfm gfm-commit has-tooltip">b9709cac</a>) and resolving conflicts, which helped a bit, but found it more difficult when things went wrong afterwards. Any ideas would be appreciated.</p>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/948">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/5e370986224f93599cf10a998b8370fe/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/948"}}</script>
</p>
</div>
</body>
</html>