<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://gitlab.com/rockdaboot">Tim Rühsen</a>
started a new discussion
on <a href="https://gitlab.com/gnutls/gnutls/merge_requests/961#note_154985964">devel/check_if_signed</a>:
</p>
<table>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="15" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
15
</td>
<td class="diff-line-num new_line" data-linenumber="15" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
15
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC15" class="line" lang="shell"><span class="c" style="color: #998; font-style: italic;"># create list of commits of the current branch</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="16" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
16
</td>
<td class="diff-line-num new_line" data-linenumber="16" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
16
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC16" class="line" lang="shell"><span class="nv" style="color: #008080;">commits</span><span class="o" style="font-weight: 600;">=</span><span class="k" style="font-weight: 600;">$(</span>git rev-list <span class="nt" style="color: #000080;">--no-merges</span> <span class="nv" style="color: #008080;">$CI_MERGE_REQUEST_TARGET_BRANCH_NAME</span>..<span class="nv" style="color: #008080;">$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME</span><span class="k" style="font-weight: 600;">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="">
<td class="diff-line-num old_line" data-linenumber="17" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
17
</td>
<td class="diff-line-num new_line" data-linenumber="17" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
17
</td>
<td class="line_content noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC17" class="line" lang="shell"></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="">
<td class="diff-line-num new old_line" data-linenumber="18" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="18" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
18
</td>
<td class="line_content new noteable_line" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC18" class="line" lang="shell"><span class="k" style="font-weight: 600;">if </span><span class="nb" style="color: #0086b3;">test</span> <span class="nv" style="color: #008080;">$?</span> <span class="nt" style="color: #000080;">-ne</span> 0<span class="p">;</span><span class="k" style="font-weight: 600;">then</span></span>
</pre>
</td>
</tr>
</table>
<div style="">
<p dir="auto">That's not how it works. I tried it locally with <code>a..b</code>, got the same error as mentioned in <a href="https://gitlab.com/gnutls/gnutls/merge_requests/960" data-original="!960" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="26491002" data-reference-type="merge_request" data-container="body" data-placement="bottom" title="Detect malloc failure." class="gfm gfm-merge_request has-tooltip">!960</a>, the script stopped with <code>$?</code> being 0. Please see <a href="https://gitlab.com/gnutls/gnutls/merge_requests/962" data-original="!962" data-link="false" data-link-reference="false" data-project="179611" data-merge-request="26545854" data-reference-type="merge_request" data-container="body" data-placement="bottom" title="Let check_if_signed fail if git fails" class="gfm gfm-merge_request has-tooltip">!962</a> for a working and more general approach (in case of command failure in other places).</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/961#note_154985964">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/5ba10dad7ddca034e1b26e7d38ec9f8b/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/961#note_154985964"}}</script>
</p>
</div>
</body>
</html>