<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p class="details" style="font-style: italic; color: #777;">
Project:Branches: ametzler/gnutls:tmp-ametzler-gcc9-build-error → gnutls/gnutls:master
</p>
<div>
<p dir="auto">This fixes the error reported in <a href="https://bugs.debian.org/925701" rel="nofollow noreferrer noopener" target="_blank">https://bugs.debian.org/925701</a> - Gnutls FTBFS with gcc-9 due to these changes:</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">GCC 9 also passes the linker option --as-needed by default; typical</span>
<span id="LC2" class="line" lang="plaintext">build issues are passing libraries before object files to the linker,</span>
<span id="LC3" class="line" lang="plaintext">or underlinking of convenience libraries built from the same source.</span></code></pre>
<p dir="auto">To reproduce I had to configure gnutls for installation into a multiarch path:
<code>--prefix=/usr --libdir=\${prefix}/lib/x86_64-linux-gnu</code></p>
<p dir="auto">I have found two issues: libecore.la is underlinked, -ldl missing.</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">/usr/bin/ld: ./.libs/libecore.a(libecore_la-eina_module.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'</span>
<span id="LC2" class="line" lang="plaintext">/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libdl.so: error adding symbols: DSO missing from command line</span></code></pre>
<p dir="auto">cipher-openssl-compat has wrong order, due to setting cipher_openssl_compat_LDFLAGS instead of cipher_openssl_compat_LDADD</p>
<pre class="code highlight js-syntax-highlight plaintext" lang="plaintext" v-pre="true"><code><span id="LC1" class="line" lang="plaintext">libtool: link: gcc-9 [...] -Wabi=11 -fdiagnostics-show-option -g -O2 /usr/lib/x86_64-linux-gnu/libcrypto.so -Wl,-rpath -Wl,/usr/lib/x86_64-linux-gnu -o .libs/cipher-openssl-compat cipher-openssl-compat.o ../.libs/libutils.a /dev/shm/gnutls.git/b4deb/lib/.libs/libgnutls.so -lp11-kit -lidn2 -lunistring -ltasn1 -lnettle -lhogweed -lgmp ../../gl/.libs/libgnu.a ../../lib/.libs/libgnutls.so</span>
<span id="LC2" class="line" lang="plaintext">/usr/bin/ld: cipher-openssl-compat.o: in function `cipher_test':</span>
<span id="LC3" class="line" lang="plaintext">/dev/shm/gnutls.git/b4deb/tests/slow/../../../tests/slow/cipher-openssl-compat.c:42: undefined reference to `EVP_get_cipherbyname'</span>
<span id="LC4" class="line" lang="plaintext">/usr/bin/ld: /dev/shm/gnutls.git/b4deb/tests/slow/../../../tests/slow/cipher-openssl-compat.c:146: undefined reference to `EVP_CipherInit_ex'</span>
<span id="LC5" class="line" lang="plaintext">[...]</span></code></pre>
<h2 dir="auto">
<a id="user-content-checklist" class="anchor" href="#checklist" aria-hidden="true"></a>Checklist</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" checked disabled> Commits have <code>Signed-off-by:</code> with name/author being identical to the commit author</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Code modified for feature</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with functionality tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Test suite updated with negative tests</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Documentation updated / NEWS entry present (for non-trivial changes)</li>
</ul>
<h2 dir="auto">
<a id="user-content-reviewers-checklist" class="anchor" href="#reviewers-checklist" aria-hidden="true"></a>Reviewer's checklist:</h2>
<ul class="task-list" dir="auto">
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Any issues marked for closing are addressed</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> There is a test suite reasonably covering new functionality or modifications</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>
</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>
<li class="task-list-item">
<input type="checkbox" class="task-list-item-checkbox" disabled> No obvious mistakes in the code</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/966">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/35358fd683d3226a6950a999b0264a09/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/966"}}</script>
</p>
</div>
</body>
</html>