<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=utf-8" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<div style="">

<p dir="auto">Reviewer's checklist:</p>

<ul class="task-list" dir="auto">

<li class="task-list-item">

<input type="checkbox" class="task-list-item-checkbox" checked disabled> Any issues marked for closing are addressed</li>

<li class="task-list-item">

<input type="checkbox" class="task-list-item-checkbox" checked disabled> There is a test suite reasonably covering new functionality or modifications</li>

<li class="task-list-item">

<input type="checkbox" class="task-list-item-checkbox" checked disabled> Function naming, parameters, return values, types, etc., are consistent and according to <code>CONTRIBUTION.md</code>

</li>

<li class="task-list-item">

<input type="checkbox" class="task-list-item-checkbox" disabled> This feature/change has adequate documentation added</li>

<li class="task-list-item">

<input type="checkbox" class="task-list-item-checkbox" checked disabled> No obvious mistakes in the code</li>

</ul>

<p dir="auto">The issue marked to be addressed mention downgrade to TLS1.2, but I agree it is sufficient to decline authentication if there is no usable key.</p>

<p dir="auto">I liked the solution used to test this by wrapping softhsm.</p>

<p dir="auto">I did not mark the documentation checkbox because I'm not sure if further documentation is needed.</p>

<p dir="auto">LGTM, r+</p>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/967#note_157943800">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/2503903149da40b6a385df14815460d7/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/967#note_157943800"}}</script>

</p>

</div>

</body>

</html>