<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">

<html lang="en">

<head>

<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">

<title>

GitLab

</title>

<style>img {

max-width: 100%; height: auto;

}

</style>

</head>

<body>

<div class="content">

<div style="">

<p dir="auto">My final review:</p>

<ul dir="auto">

<li>In tests/*dh-compute.c the fail() arguments print <strong>LINE</strong> and <strong>func</strong> but these are already included in the output of fail()</li>

<li>In lib/nettle/pk.c the FIPS check is only run when <code>PK_DERIVE_TLS13</code> flag is set. That means it will not be run under TLS1.2. Maybe a new flag to indicate known parameters?</li>

<li>There is a typo in two of the commit messages 'paramters', and 'tLS 1.3'</li>

</ul>

</div>

</div>

<div class="footer" style="margin-top: 10px;">

<p style="font-size: small; color: #777;">

—

<br>

Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/990#note_173618113">view it on GitLab</a>.

<br>

You're receiving this email because of your account on gitlab.com.

If you'd like to receive fewer emails, you can

<a href="https://gitlab.com/sent_notifications/8e197b581f06ce2fb9d002971b0207e8/unsubscribe">unsubscribe</a>

from this thread or

adjust your notification settings.

<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/990#note_173618113"}}</script>

</p>

</div>

</body>

</html>