<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<div style="">
<p dir="auto">I've amended my previous patch, to avoid the <code>assert()</code>.</p>
<blockquote dir="auto">
<p><code>_gnutls_set_strdatum</code> also allows <code>data == NULL</code> as long as the <code>data_size</code> argument is 0.</p>
</blockquote>
<p dir="auto">I'll comment inline.</p>
<blockquote dir="auto">
<p><code>warn_unused_result</code> immediately warns us if we introduce an unchecked call in the future.
<code>nonnull((1))</code> triggers an error on clang's build-scan if the first argument could be NULL.</p>
</blockquote>
<p dir="auto">My concern was a function calling <code>set()</code>, then acting assuming the value is initialized to either <code>NULL</code> or something else irrespective of failure or success.</p>
<blockquote dir="auto">
<p>All calls to <code>_gnutls_set_datum</code> and <code>_gnutls_set_strdatum</code> now check their return value and fail out on error. I also manually skimmed through the places where we call one of those functions. LGTM.</p>
</blockquote>
<p dir="auto">Thank you for that.</p>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_175390188">view it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.com.
If you'd like to receive fewer emails, you can
<a href="https://gitlab.com/sent_notifications/50bb931a29061ecf693a45ee0f7549db/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge request","url":"https://gitlab.com/gnutls/gnutls/merge_requests/1002#note_175390188"}}</script>
</p>
</div>
</body>
</html>